Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an info box showing more context during the info command #391

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

bmonkman
Copy link
Contributor

@bmonkman bmonkman commented Jul 9, 2021

No description provided.

@bmonkman bmonkman requested a review from davidcheung July 9, 2021 22:40
Copy link
Contributor

@davidcheung davidcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -17,7 +17,7 @@ func TestGetParam(t *testing.T) {
t.Run("Should execute params without prompt", func(t *testing.T) {
param := moduleconfig.Parameter{
Field: "account-id",
Execute: "echo \"my-acconut-id\"",
Execute: "echo \"my-account-id\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't the fix, just noticed it while I was in there. 😂

@bmonkman bmonkman merged commit bdc1ccd into main Jul 19, 2021
@bmonkman bmonkman deleted the add-info-box-to-init-command branch July 19, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants