Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override registry #470

Merged

Conversation

JeanPinzon
Copy link
Contributor

@JeanPinzon JeanPinzon commented Jun 13, 2022

Issue: #469

  • Add registry.yaml with the default stacks;
  • Add the parameter registry-file-path to override the file path on the command init. It can be a local or a github path.

@JeanPinzon JeanPinzon changed the title Feat/ability to override registries Ability to override registry Jun 13, 2022
@JeanPinzon JeanPinzon marked this pull request as ready for review June 13, 2022 20:10
Copy link
Contributor

@davidcheung davidcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!!
I wonder going forward if we still need to use the local-module-path given we can override the entire registry, but we can remove it in a different PR if we find ourselves not using it anymore

@JeanPinzon
Copy link
Contributor Author

Thanks for your contribution!! I wonder going forward if we still need to use the local-module-path given we can override the entire registry, but we can remove it in a different PR if we find ourselves not using it anymore

I'm not sure if local-module-path is just used on registry, but if so, it would be interesting to remove it and put the entire URL on the registry file. With this approach, it would be possible to have stacks with templates from different GitHub accounts.

@JeanPinzon
Copy link
Contributor Author

Please let me know if you think it should be implemented on this PR 😄

@davidcheung
Copy link
Contributor

Yeah i think the registry file "should" cover all the use cases, go-getter allows a pretty wide range of paths
it is a breaking change though (which only affects development on modules)

@bmonkman what do u think about removing the local-module-path entirely?

@bmonkman
Copy link
Contributor

Let's just leave the local module path for now and remove it separately later if we truly end up not using it. I think it's still probably useful as-is when using default values.

Copy link
Contributor

@bmonkman bmonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @JeanPinzon!

@bmonkman bmonkman merged commit 5522131 into commitdev:main Jun 14, 2022
@bmonkman bmonkman linked an issue Jun 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to override or append to registry
3 participants