-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to override registry #470
Ability to override registry #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!!
I wonder going forward if we still need to use the local-module-path
given we can override the entire registry, but we can remove it in a different PR if we find ourselves not using it anymore
I'm not sure if |
Please let me know if you think it should be implemented on this PR 😄 |
Yeah i think the registry file "should" cover all the use cases, go-getter allows a pretty wide range of paths @bmonkman what do u think about removing the local-module-path entirely? |
Let's just leave the local module path for now and remove it separately later if we truly end up not using it. I think it's still probably useful as-is when using default values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @JeanPinzon!
Issue: #469
registry.yaml
with the default stacks;registry-file-path
to override the file path on the commandinit
. It can be a local or a github path.