Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): fix get_commits deliminator #354

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Feb 24, 2021

Description

  • fix(git): fix get_commits deliminator
    • when we merge a pull request, it generates a commit without breakline

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Changelog should be generated correctly

Steps to Test This Pull Request

  1. Run cz ch in commitizen (or any project that had merged pull request)

Additional context

#315

@Lee-W Lee-W requested a review from woile February 24, 2021 02:03
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #354 (2756e91) into master (4671258) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   97.29%   97.53%   +0.24%     
==========================================
  Files          35       39       +4     
  Lines         999     1340     +341     
==========================================
+ Hits          972     1307     +335     
- Misses         27       33       +6     
Flag Coverage Δ
unittests 97.53% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/changelog.py 95.77% <100.00%> (ø)
commitizen/git.py 96.62% <100.00%> (ø)
commitizen/bump.py 100.00% <0.00%> (ø)
commitizen/exceptions.py 100.00% <0.00%> (ø)
commitizen/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d098416...2756e91. Read the comment docs.

@woile woile merged commit f6eaa8e into master Feb 24, 2021
@woile woile deleted the fix-git-commit-parsing branch February 24, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants