chore(deps): upgrade and pin optional dependency @commitlint/load and fix tests #223
+269
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jimthedev 😄 |
|
Why was this closed and not merged? @jimthedev Is this library no longer maintained? |
|
Sorry, we can reopen it and can merge. I was making the same change in another branch. We lost some CI data so whether something is pass or not was opaque in some repos. If this passes CI then I'll merge yours. |
|
@lloydjatkinson would you be willing to just resolve the conflicts. As you said, we can use ^ but I don't know why we want to add it into the deps in addition to optional deps. My instinct was to also ask you to remove it from deps and just leave it in optional. I don't really use optional deps much so perhaps having it in both places is the correct move? If you have opinions on it please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
@commitlint/loadand also pins the version, this fixes the unit tests that have been failing for at least a year. The current version of@commitlint/loadis significantly far ahead in major versions and these unit tests fail on those recent versions so this patch upgrade is adequate for now.The
>(greater than) was also removed as I believe this was a mistake to begin with. On testing, it was found that8.x.xwas being used which is two major versions ahead of the current. This caused the tests to fail.