Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file perrmisions appear to be wrong #754

Closed
jpbelleau opened this issue Sep 24, 2024 · 7 comments
Closed

Config file perrmisions appear to be wrong #754

jpbelleau opened this issue Sep 24, 2024 · 7 comments

Comments

@jpbelleau
Copy link

It appears the file permissions for the Granted config directory, when created, are wrong. We saw the change in behavior with the 0.34 release. If fails when running granted registry add .... Looking at #751, the wrong permissions were used for directory creation.

@chrnorm
Copy link
Contributor

chrnorm commented Sep 24, 2024

Thanks for flagging this @jpbelleau, I'm working on a fix for this now

@jpbelleau
Copy link
Author

jpbelleau commented Sep 24, 2024

I have one done and working to open a PR.

@chrnorm
Copy link
Contributor

chrnorm commented Sep 24, 2024

Thankyou. My proposed change is to simply revert #751

@jpbelleau
Copy link
Author

I have not sent a change to granted yet and have some setup to do. I found the 2 offending issues and no revert should be needed.

@chrnorm
Copy link
Contributor

chrnorm commented Sep 24, 2024

No problems. I've just raised #755. If you are able to note the offending issues by dropping a comment on the PR that would be great. I am keen to revert here as it looks like the PR inadvertently changed some files from 0600 to 0644 - I think these files can be left as 0600.

@jpbelleau
Copy link
Author

Added PR for the config folder fixes

@chrnorm
Copy link
Contributor

chrnorm commented Sep 24, 2024

@jpbelleau this is now released in v0.34.1, thanks again for the report. The release binaries are now building and will be live in the next 10 minutes or so. I ended up merging my PR over yours because I wanted to shift the permissions back to 0600. I marked you as a coauthor on the PR though to highlight your contribution - thankyou so much for your help here.

Some context too on why #751 was implemented at all - @JoshuaWilkes noticed recently that that the ~/.granted/config file was executable on his machine, and the PR was put up as a response to this. Upon reviewing the change though I think that the Josh's ~/.granted/config file may have been made executable outside of Granted, as I was unable to reproduce this myself.

@chrnorm chrnorm closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants