Use ini package for config file parsing #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eddie023
reviewed
Oct 28, 2022
Eddie023
reviewed
Oct 28, 2022
Eddie023
reviewed
Oct 28, 2022
Eddie023
approved these changes
Nov 1, 2022
This was referenced Nov 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out configparser in favour of gopkg.in/ini.v1
The swap is mostly like for like and I have not made an attempt at refactoring our parsing logic in this PR.
The benefit gained from this swap is that comments are now supported in configuration files.
When performing write operations, Granted will no longer remove comments from the configuration files!
The ini package makes it simple to write tests where we define the config files using a string rather than reading and writing to the filesystem