Revert additional stream closed polling on proxy command #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerjrr
approved these changes
Nov 12, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 18, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [common-fate/granted](https://github.com/common-fate/granted) | minor | `v0.35.1` -> `v0.36.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>common-fate/granted (common-fate/granted)</summary> ### [`v0.36.3`](https://github.com/common-fate/granted/releases/tag/v0.36.3) [Compare Source](common-fate/granted@v0.36.2...v0.36.3) #### Changelog - [`8785167`](common-fate/granted@8785167) Revert additional stream closed polling on proxy command ([#​802](common-fate/granted#802)) - [`8547465`](common-fate/granted@8547465) use sso role name from grant output for eks and rds access ([#​803](common-fate/granted#803)) Download this release by following our [getting started guide](https://docs.commonfate.io/granted/getting-started). ### [`v0.36.2`](https://github.com/common-fate/granted/releases/tag/v0.36.2) [Compare Source](common-fate/granted@v0.36.1...v0.36.2) #### Changelog - [`eeccfba`](common-fate/granted@eeccfba) Add Vivaldi browser support ([#​797](common-fate/granted#797)) - [`eeec10e`](common-fate/granted@eeec10e) Fix the proxy command not detecting that the stream had closed remotely ([#​799](common-fate/granted#799)) - [`062ec34`](common-fate/granted@062ec34) Re authenticate with common fate during registry sync if token is expired ([#​798](common-fate/granted#798)) - [`b165600`](common-fate/granted@b165600) Service flag support for AWS Organizations ([#​800](common-fate/granted#800)) - [`cc23acc`](common-fate/granted@cc23acc) fix: pass external_id for credential process and IAM ([#​790](common-fate/granted#790)) Download this release by following our [getting started guide](https://docs.commonfate.io/granted/getting-started). ### [`v0.36.1`](https://github.com/common-fate/granted/releases/tag/v0.36.1) [Compare Source](common-fate/granted@v0.36.0...v0.36.1) #### Changelog - [`fd86607`](common-fate/granted@fd86607) Switch out huh for survey with a custom renderer template ([#​794](common-fate/granted#794)) Download this release by following our [getting started guide](https://docs.commonfate.io/granted/getting-started). ### [`v0.36.0`](https://github.com/common-fate/granted/releases/tag/v0.36.0) [Compare Source](common-fate/granted@v0.35.2...v0.36.0) #### What's Changed - RDS Plugin: Allow server specified default port by [@​VigneshSelvaraj96](https://github.com/VigneshSelvaraj96) in common-fate/granted#788 - Add Granted EKS Proxy command by [@​JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#787 - update handling for ports in proxy commands by [@​JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#789 **Full Changelog**: common-fate/granted@v0.35.2...v0.36.0 ### [`v0.35.2`](https://github.com/common-fate/granted/releases/tag/v0.35.2) [Compare Source](common-fate/granted@v0.35.1...v0.35.2) #### What's Changed - Changes waf shortcut to use v2 home page, rather than WAF classic home. by [@​CodyDunlap](https://github.com/CodyDunlap) in common-fate/granted#775 - Fix service map comma and formatting by [@​chrnorm](https://github.com/chrnorm) in common-fate/granted#776 - update asdf tool-versions golang to 1.22 by [@​chrnorm](https://github.com/chrnorm) in common-fate/granted#774 - tidy unused packages and variables by [@​chrnorm](https://github.com/chrnorm) in common-fate/granted#773 - RDS proxy command should be filterable by [@​JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#777 - feat: sort service map and add aws bedrock as a recognized service. by [@​felipewnp](https://github.com/felipewnp) in common-fate/granted#784 #### New Contributors - [@​felipewnp](https://github.com/felipewnp) made their first contribution in common-fate/granted#784 **Full Changelog**: common-fate/granted@v0.35.1...v0.35.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
After additional testing post release I found that the original issue was actually fixed by adding
defer clientConn.Close()in the existing copy go routines.The additional polling and log message were thus not needed.
Why?
How did you test it?
I introduced the same set of error conditions in the proxy service and observed that the desired behaviour of the connection between granted and the db client behaviour was preserved after this change.
Potential risks
Is patch release candidate?
Link to relevant docs PRs