Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize codebase #9

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Modernize codebase #9

merged 1 commit into from
Mar 7, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Mar 4, 2022

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2022

This pull request fixes 21 alerts when merging 9006466 into 47d455e - view on LGTM.com

fixed alerts:

  • 16 for Unused local variable
  • 4 for 'import *' may pollute namespace
  • 1 for Variable defined multiple times

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #9 (a823d3b) into main (47d455e) will increase coverage by 3.69%.
The diff coverage is 65.00%.

❗ Current head a823d3b differs from pull request most recent head 81e8217. Consider uploading reports for the commit 81e8217 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   38.57%   42.27%   +3.69%     
==========================================
  Files           6        5       -1     
  Lines        1304     1346      +42     
  Branches      212      244      +32     
==========================================
+ Hits          503      569      +66     
+ Misses        754      713      -41     
- Partials       47       64      +17     
Impacted Files Coverage Δ
cwlprov/tool.py 28.78% <52.83%> (+1.36%) ⬆️
cwlprov/ro.py 66.66% <68.51%> (-8.21%) ⬇️
cwlprov/prov.py 66.53% <80.00%> (+17.40%) ⬆️
cwlprov/utils.py 59.25% <90.00%> (+13.42%) ⬆️
cwlprov/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d455e...81e8217. Read the comment docs.

@mr-c mr-c merged commit eff50da into main Mar 7, 2022
@mr-c mr-c deleted the 2022_refresh branch March 7, 2022 14:46
@lgtm-com
Copy link

lgtm-com bot commented Mar 7, 2022

This pull request fixes 21 alerts when merging 81e8217 into 47d455e - view on LGTM.com

fixed alerts:

  • 16 for Unused local variable
  • 4 for 'import *' may pollute namespace
  • 1 for Variable defined multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant