Merge pull request #179 from danielberndt/patch-1

Don't decode url before encoding it again
commonmark · Jan 9, 2020 · cd03322 · cd03322
2 parents ca71e64 + edd1f4a
commit cd03322
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/common.js b/lib/common.js
@@ -1,7 +1,6 @@
 "use strict";
 
 var encode = require('mdurl/encode');
-var decode = require('mdurl/decode');
 
 var C_BACKSLASH = 92;
 
@@ -56,7 +55,7 @@ var unescapeString = function(s) {
 
 var normalizeURI = function(uri) {
     try {
-        return encode(decode(uri));
+        return encode(uri);
     }
     catch(err) {
         return uri;

diff --git a/test/regression.txt b/test/regression.txt
@@ -122,7 +122,15 @@ Double-encoding.
 ```````````````````````````````` example
 [XSS](javascript&amp;colon;alert%28&#039;XSS&#039;%29)
 .
-<p><a href="javascript&amp;colon;alert('XSS')">XSS</a></p>
+<p><a href="javascript&amp;colon;alert%28'XSS'%29">XSS</a></p>
+````````````````````````````````
+
+PR #179
+
+```````````````````````````````` example
+[link](https://www.example.com/home/%25batty)
+.
+<p><a href="https://www.example.com/home/%25batty">link</a></p>
 ````````````````````````````````
 
 Issue commonamrk#517 - script, pre, style close tag without