dingus: add dependency version requirements #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vassudanagunta
force-pushed
the
dingus-fix-deps
branch
from
6118f59
to
5be7169
Compare
vassudanagunta
changed the title
|
Thanks! Can I suggest bumping up the lodash version to the latest? |
vassudanagunta
force-pushed
the
dingus-fix-deps
branch
from
5be7169
to
de1eeef
Compare
|
Done! I updated the requirement to match Are you not concerned with incompatibilities that might be introduced with major version changes, i.e. |
|
Indeed. Let's change to using |
vassudanagunta
force-pushed
the
dingus-fix-deps
branch
from
de1eeef
to
8e6d073
Compare
|
done! |
Dingus was rendering incorrectly with Bootstrap 4. Added a bower.json which requires Bootstrap, jQuery and Lodash with major version equal to what's currently live. Likewise the minimum patch version.
vassudanagunta
force-pushed
the
dingus-fix-deps
branch
from
8e6d073
to
efdfbe5
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dingus was rendering incorrectly with Bootstrap 4. Added a bower.json
which requires Bootstrap, jQuery and Lodash with major version equal
to what's currently live. Likewise the minimum patch version.