This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
BAU Dont override user workspace colour preferences #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfount
force-pushed
the
BAU-fix-colour-settings
branch
from
7dd1e17 to
de6543a
Compare
samuelhwilliams
approved these changes
Oct 23, 2024
Remove the colour customisations specified at the repository configuration level. Developers can still specify their own customisations for the workspaces. The current version of vscode has very little contrast with the chosen colour scheme which makes it hard to use. This also removes an override for formatting on saving which can also now be chosen by the developer based on their setup -- formatting issues should be caught in pre-commit checks both locally and during the CI process.
sfount
force-pushed
the
BAU-fix-colour-settings
branch
from
de6543a to
419df7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Remove the colour customisations specified at the repository configuration level.
Developers can still specify their own customisations for the workspaces.
The current version of vscode has very little contrast with the chosen colour scheme which makes it hard to use.
This also removes an override for formatting on saving which can also now be chosen by the developer based on their setup -- formatting issues should be caught in pre-commit checks both locally and during the CI process.
Example of low contrast icons with the repository specified colour scheme
[ ] Unit tests and other appropriate tests added or updated[ ] README and other documentation has been updated / added (if needed)