Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH components #21

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

GH components #21

wants to merge 13 commits into from

Conversation

gonzalocasas
Copy link
Contributor

@gonzalocasas gonzalocasas commented Oct 4, 2021

This is still a draft pull request, it adds a first batch of GH components but perhaps more importantly, sets up the project to add more in the coming days.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas gonzalocasas marked this pull request as draft October 4, 2021 07:56
Copy link
Contributor

@beverlylytle beverlylytle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a draft, but I made some comments on the docs anyway... ;)

{
"name": "speed",
"description": "Integer specifying TCP translational speed in mm/s.",
"typeHintID": "int"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not float?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not float... ABB RAPID is an inflexible friend sometimes... :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but

if not speed or speed < 0.01:
            add_warning('Speed must be greater or equal to 0.01 mm/s.')

gonzalocasas and others added 4 commits October 4, 2021 14:55
…data.json

Co-authored-by: beverlylytle <57254617+beverlylytle@users.noreply.github.com>
Co-authored-by: beverlylytle <57254617+beverlylytle@users.noreply.github.com>
Copy link
Contributor

@beverlylytle beverlylytle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a couple...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants