Seurat v5 compatibility update #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request compbiomed#756 from mingl1997/devel
|
Hi @mingl1997, I don't think the "options" change should be added to the example as it may not be something we want users to systematically do. I think you should add it to the unit test for now to get it to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
-Fixed Seurat problems by incorporating Seurat v5 functions
-Added .dockerignore file for easier docker image testing and building
-Updated shiny webapp to incorporate Seurat v5 support
Still in progress:
-Update all functions to support calling Seurat accessors (instead of hardcoding)
-Figure out why plotting only one marker gene with Seurat v5 doesn't work