Fix: Interview Export Errors #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds fetch and blob so that the browser can explicitly fetch the file before download
This reverts commit c621c41.
need to use blob within exportinterviews like other exports
when stack is too big it exceeds file size for endpoint
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jthrilly
requested changes
Mar 1, 2024
This reverts commit fd1893f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting interview sessions was not working properly on Safari and Firefox. This was due to the way the useDownload hook was implemented and how it creates an "a" element to trigger the download.
On some browsers, there are increased security restrictions around programmatically initiated downloads. The way to work with this is to create a blob and use its url as the href for the "a" element. Other uses of useDownload in this project create the blob before calling the download method, and pass it the blob's url. ExportInterviewsDialog was not implemented in the same way.
Therefore, this fix implements using blob and its url in ExportInterviewsDialog which fixes the issue. Future refactoring could be done to move this functionality all within the useDownload hook.