This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Allow multiple values for exactly/not predicate #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability to provide multiple values to the `exactly` and `not` predicates. This applies to categorical variables only. The comparison is done using the `isEqual` lodash method, with sorting applied to the values before comparison. This means that the order of the values provided to the predicate does not matter. Architect will need to be updated to produce rules that use this new functionality.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to provide multiple values to the
exactlyandnotpredicates. This applies to categorical variables only.The comparison is done using the
isEquallodash method, with sorting applied to the values before comparison. This means that the order of the values provided to the predicate does not matter.Architect will need to be updated to produce rules that use this new functionality.