Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize .pep.xml files #101

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

levitsky
Copy link

@levitsky levitsky commented Oct 9, 2024

This is a simple regex change that allows _infer_filetype to recognize .pep.xml files as well as .pepxml.

Copy link
Member

@RalfG RalfG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @levitsky!

@RalfG RalfG added the enhancement Improvement of an existing feature label Oct 31, 2024
@levitsky
Copy link
Author

I'm not sure why the errors happen but then seem unrelated to my changes, they occur in a test for ParquetWriter.

@RalfG
Copy link
Member

RalfG commented Nov 1, 2024

Indeed unrelated. They're due to a new version of pyarrow changing the hashes of the written files. Not the best way of testing... 😅

@RalfG RalfG merged commit 27b8591 into compomics:main Nov 1, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants