Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of x-* service names as depends_on keys #687

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Sep 30, 2024

@ndeloof ndeloof requested review from glours and jhrotko September 30, 2024 08:05
loader/loader_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhrotko jhrotko enabled auto-merge (rebase) October 2, 2024 09:55
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@jhrotko jhrotko merged commit f8ea4c3 into compose-spec:main Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can not depends_on containers that start with x-
3 participants