add (missing) deploy.resources.devices.options #691
Conversation
| @@ -27,6 +27,7 @@ type DeviceRequest struct { | |||
| Driver string `yaml:"driver,omitempty" json:"driver,omitempty"` | |||
| Count DeviceCount `yaml:"count,omitempty" json:"count,omitempty"` | |||
| IDs []string `yaml:"device_ids,omitempty" json:"device_ids,omitempty"` | |||
| Options Mapping `yaml:"options,omitempty" json:"options,omitempty"` | |||
There was a problem hiding this comment.
We are not doing anything with this yet. Should we wait for the upcoming work to add this?
There was a problem hiding this comment.
we are not because this was missing in compose-go, but moby API has support for options (sorry, can't post a direct link to DeviceRequest nested struct)
Driver-specific options, specified as a key/value pairs. These options are passed directly to the driver.
There was a problem hiding this comment.
Apologies, re-reading my comment I realise I did not express myself correctly. I meant, in compose-go you defined the Options but not doing any actual implementation with it. All I am saying is should we save this change for later for when we augment the options section or should we already implement the moby api call in this PR?
There was a problem hiding this comment.
compose-go never includes implementation; this is docker/compose role to do so
There was a problem hiding this comment.
With this PR merged, we need to handle manually the parsing of options attributes, I think this is what @jhrotko wanted to mention
There was a problem hiding this comment.
fixed, +added a test case to cover loading DeviceRequest
ndeloof
force-pushed
the
device_options
branch
2 times, most recently
from
a464071 to
fe8dfec
Compare
types/device.go
Outdated
| @@ -92,6 +93,13 @@ func (d *DeviceRequest) DecodeMapstructure(value interface{}) error { | |||
| d.IDs = ids | |||
| d.Count = DeviceCount(len(ids)) | |||
| } | |||
|
|
|||
| if options, ok := v["options"].(map[string]any); ok { | |||
| d.Options = Mapping{} | |||
There was a problem hiding this comment.
Can't we do this d.Options = Mapping{} even if there isn't any option defined to avoid nil issue on the client side?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
device_options
branch
from
fe8dfec to
d01d1c6
Compare
defined by the spec but missing in go struct for some legacy reasons