Skip to content

Commit

Permalink
Updated README for ECS Settings. Pending clearer pre-requesites doc page
Browse files Browse the repository at this point in the history
  • Loading branch information
John Preston committed Apr 30, 2020
1 parent e2c8489 commit 0b8681b
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 12 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ coverage: ## check code coverage quickly with the default Python
docs: clean-c9 ## generate Sphinx HTML documentation, including API docs
rm -f docs/ecs_composex.rst
rm -f docs/modules.rst
find docs -name "ecs_composex.*.rst" -print -delete
sphinx-apidoc -o docs/ ecs_composex
$(MAKE) -C docs clean
$(MAKE) -C docs html
Expand Down
26 changes: 15 additions & 11 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -101,20 +101,24 @@ ECS Account settings can be found at https://docs.aws.amazon.com/AmazonECS/lates

.. code-block:: bash
aws ecs put-account-setting --name awsvpcTrunking --value enabled
aws ecs put-account-setting --name serviceLongArnFormat --value enabled
aws ecs put-account-setting --name taskLongArnFormat --value enabled
aws ecs put-account-setting --name containerInstanceLongArnFormat --value enabled
aws ecs put-account-setting --name containerInsights --value enabled
aws ecs put-account-setting-default --name awsvpcTrunking --value enabled
aws ecs put-account-setting-default --name serviceLongArnFormat --value enabled
aws ecs put-account-setting-default --name taskLongArnFormat --value enabled
aws ecs put-account-setting-default --name containerInstanceLongArnFormat --value enabled
aws ecs put-account-setting-default --name containerInsights --value enabled
If you have multiple profiles and use awsume you could iterate over each account and run the above commands to apply it
for your profiles as you switch to them.
.. warning::
.. hint::

If you do not do that as the root user of the account, you will have to enable that for IAM users or roles specifically.
A Role/Group/User can have an IAM policy allowing them to put the ecs account settings, but then these settings will only
apply to the role / user that ran the command.
If you want to enable these settings for a specific IAM role you can assume yourself, from CLI you can use `aws ecs put-account-setting` as opposed to `aws ecs put-account-setting-default`

.. code-block:: bash
aws ecs put-account-setting --name awsvpcTrunking --value enabled
aws ecs put-account-setting --name serviceLongArnFormat --value enabled
aws ecs put-account-setting --name taskLongArnFormat --value enabled
aws ecs put-account-setting --name containerInstanceLongArnFormat --value enabled
aws ecs put-account-setting --name containerInsights --value enabled
IAM Permissions to execute ECS ComposeX
----------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion ecs_composex/vpc/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from ecs_composex.common.aws import CURATED_AZS, BUCKET_NAME
from ecs_composex.vpc import create_vpc_template
from ecs_composex import XFILE_DEST, DIR_DEST
from ecs_composex.common.ecs_composex import XFILE_DEST, DIR_DEST
from ecs_composex.common.files import FileArtifact


Expand Down

0 comments on commit 0b8681b

Please sign in to comment.