Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] service.deploy.labels: ecs.ephemeral.storage not working #719

Closed
thorfi opened this issue Nov 29, 2023 · 2 comments · Fixed by #720 or #721
Closed

[BUG] service.deploy.labels: ecs.ephemeral.storage not working #719

thorfi opened this issue Nov 29, 2023 · 2 comments · Fixed by #720 or #721
Assignees
Labels
bug Something isn't working

Comments

@thorfi
Copy link
Contributor

thorfi commented Nov 29, 2023

Bug

service.deploy.labels: ecs.ephemeral.storage does not result in the correct TaskDefinition.EphemeralStorage.SizeInGiB

Steps to reproduce the behavior:

  1. pip install
  2. cli
  3. Docker compose file
services:
  foo:
    deploy:
      labels:
        ecs.ephemeral.storage: 200
  1. Output CloudFormation file foo.yaml
  EcsTaskDefinition:
    Properties:
      ...
      EphemeralStorage:
        Ref: AWS::NoValue
      ...
    Type: AWS::ECS::TaskDefinition

Expected behavior

Output CloudFormation file foo.yaml

  EcsTaskDefinition:
    Properties:
      ...
      EphemeralStorage:
        Fn::If:
          - UseFargate
          - SizeInGiB: 200
          - Ref: AWS::NoValue
      ...
    Type: AWS::ECS::TaskDefinition

Logs

N/A

Desktop

  • OS: macOS 14.1 (Sonoma)
  • Python 3.12
  • ecs-composex v0.24.1
@thorfi thorfi added the bug Something isn't working label Nov 29, 2023
@thorfi
Copy link
Contributor Author

thorfi commented Nov 29, 2023

PR coming for this one shortly

@JohnPreston
Copy link
Member

Hey @thorfi
Thanks for reporting this. I use this label all the time in other services, and this works fine.
However, I did notice that it doesn't work for a singleton service (ECS family with a single service).
So I'll be looking into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants