Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to change the logs retention period for each individual service #171

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added the enhancement New feature or request label Aug 21, 2020
@JohnPreston JohnPreston self-assigned this Aug 21, 2020
@JohnPreston JohnPreston linked an issue Aug 21, 2020 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #171 into master will decrease coverage by 0.14%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   88.82%   88.68%   -0.15%     
==========================================
  Files          97       97              
  Lines        4171     4179       +8     
==========================================
+ Hits         3705     3706       +1     
- Misses        466      473       +7     
Impacted Files Coverage Δ
ecs_composex/ecs/__init__.py 100.00% <ø> (ø)
ecs_composex/ecs/ecs_service_config.py 84.10% <88.88%> (+0.10%) ⬆️
ecs_composex/common/stacks.py 82.90% <100.00%> (ø)
ecs_composex/ecs/ecs_service.py 86.46% <100.00%> (+0.05%) ⬆️
ecs_composex/common/files.py 77.14% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9679ec1...4ea6601. Read the comment docs.

@JohnPreston JohnPreston merged commit 6c726a9 into master Aug 21, 2020
@JohnPreston JohnPreston deleted the feature/cw-retention branch August 21, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set CW Logs retention
1 participant