Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched SQS based scaling rule and alarm #202

Merged
merged 2 commits into from
Oct 11, 2020
Merged

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston self-assigned this Oct 11, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #202 into root will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             root     #202   +/-   ##
=======================================
  Coverage   88.61%   88.61%           
=======================================
  Files         100      100           
  Lines        4443     4446    +3     
=======================================
+ Hits         3937     3940    +3     
  Misses        506      506           
Impacted Files Coverage Δ
ecs_composex/sqs/sqs_ecs.py 88.00% <ø> (ø)
ecs_composex/sqs/sqs_template.py 82.85% <ø> (ø)
ecs_composex/ecs/ecs_scaling.py 90.19% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4818cdf...4d25c83. Read the comment docs.

@JohnPreston JohnPreston merged commit 0ced643 into root Oct 11, 2020
@JohnPreston JohnPreston deleted the fix/sqs-conditions branch October 11, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant