Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup RDS DB/Clusters #211

Merged
merged 21 commits into from
Oct 16, 2020
Merged

Lookup RDS DB/Clusters #211

merged 21 commits into from
Oct 16, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston self-assigned this Oct 14, 2020
@JohnPreston JohnPreston linked an issue Oct 14, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #211 into root will increase coverage by 0.07%.
The diff coverage is 89.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #211      +/-   ##
==========================================
+ Coverage   88.62%   88.70%   +0.07%     
==========================================
  Files         100      101       +1     
  Lines        4448     4612     +164     
==========================================
+ Hits         3942     4091     +149     
- Misses        506      521      +15     
Impacted Files Coverage Δ
ecs_composex/rds/rds_aws.py 84.37% <84.37%> (ø)
ecs_composex/rds/rds_template.py 94.11% <85.71%> (-2.55%) ⬇️
ecs_composex/rds/rds_ecs.py 88.70% <91.11%> (+3.52%) ⬆️
ecs_composex/common/aws.py 92.15% <93.33%> (+1.45%) ⬆️
ecs_composex/rds/rds_perms.py 94.54% <100.00%> (+5.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985c5c8...d91294c. Read the comment docs.

@JohnPreston JohnPreston force-pushed the feature/lookup/rds branch 2 times, most recently from 7a94291 to 2dac075 Compare October 15, 2020 15:41
@compose-x compose-x deleted a comment from sonarcloud bot Oct 15, 2020
@compose-x compose-x deleted a comment from sonarcloud bot Oct 15, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston changed the title WIP - Lookup RDS DB/Clusters Lookup RDS DB/Clusters Oct 16, 2020
@JohnPreston JohnPreston merged commit 230a9d3 into root Oct 16, 2020
@JohnPreston JohnPreston deleted the feature/lookup/rds branch October 16, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-rds Lookup/Use support
1 participant