Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to classes for XResources and Compose resources #219

Merged
merged 34 commits into from
Oct 29, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added the refactor Refactoring code label Oct 23, 2020
@JohnPreston JohnPreston self-assigned this Oct 23, 2020
@JohnPreston JohnPreston changed the title Refactor/x resources mapping WIP - Refactor Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #219 into root will decrease coverage by 3.70%.
The diff coverage is 89.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #219      +/-   ##
==========================================
- Coverage   88.78%   85.08%   -3.71%     
==========================================
  Files         108      111       +3     
  Lines        4932     5182     +250     
==========================================
+ Hits         4379     4409      +30     
- Misses        553      773     +220     
Impacted Files Coverage Δ
ecs_composex/elbv2/__init__.py 0.00% <0.00%> (ø)
ecs_composex/iam/__init__.py 78.57% <50.00%> (-2.92%) ⬇️
ecs_composex/sns/sns_aws.py 70.58% <70.58%> (ø)
ecs_composex/sqs/sqs_aws.py 72.50% <72.50%> (ø)
ecs_composex/common/compose_secrets.py 80.48% <73.33%> (ø)
ecs_composex/kms/kms_aws.py 74.19% <74.19%> (ø)
ecs_composex/dns/__init__.py 75.94% <75.86%> (-3.00%) ⬇️
ecs_composex/dynamodb/dynamodb_aws.py 78.57% <77.77%> (-5.85%) ⬇️
ecs_composex/appmesh/appmesh_mesh.py 90.00% <83.33%> (-0.82%) ⬇️
ecs_composex/common/compose_volumes.py 83.33% <83.33%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5716510...2accb24. Read the comment docs.

@JohnPreston JohnPreston marked this pull request as ready for review October 29, 2020 07:41
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@JohnPreston JohnPreston changed the title WIP - Refactor Refactor to classes for XResources and Compose resources Oct 29, 2020
@JohnPreston JohnPreston merged commit d753473 into root Oct 29, 2020
@JohnPreston JohnPreston deleted the refactor/x-resources-mapping branch October 29, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant