Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing RoleArn in x-rds Lookup #233

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Allowing RoleArn in x-rds Lookup #233

merged 3 commits into from
Nov 7, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston linked an issue Nov 6, 2020 that may be closed by this pull request
@JohnPreston JohnPreston added the fix This provides a fix for an open issue label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #233 (dece037) into root (87ff32a) will decrease coverage by 3.87%.
The diff coverage is 88.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #233      +/-   ##
==========================================
- Coverage   88.27%   84.40%   -3.88%     
==========================================
  Files          99      111      +12     
  Lines        4358     5174     +816     
==========================================
+ Hits         3847     4367     +520     
- Misses        511      807     +296     
Impacted Files Coverage Δ
ecs_composex/elbv2/__init__.py 0.00% <0.00%> (ø)
ecs_composex/vpc/vpc_stack.py 66.10% <ø> (-27.12%) ⬇️
ecs_composex/vpc/vpc_aws.py 25.00% <18.18%> (-67.23%) ⬇️
ecs_composex/sns/sns_aws.py 71.42% <71.42%> (ø)
ecs_composex/sqs/sqs_aws.py 73.17% <73.17%> (ø)
ecs_composex/common/compose_secrets.py 80.48% <73.33%> (ø)
ecs_composex/kms/kms_aws.py 75.00% <75.00%> (ø)
ecs_composex/dns/__init__.py 75.94% <75.86%> (-3.00%) ⬇️
ecs_composex/rds/rds_ecs.py 78.57% <77.77%> (-6.62%) ⬇️
ecs_composex/dynamodb/dynamodb_aws.py 79.31% <78.57%> (-5.11%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22feb56...dece037. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit fb0bc4a into root Nov 7, 2020
@JohnPreston JohnPreston deleted the fix/lookup-rds branch November 7, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This provides a fix for an open issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-rds lookup - RoleArn not accepted
1 participant