Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor services to root stack #248

Merged
merged 23 commits into from
Nov 12, 2020
Merged

Conversation

JohnPreston
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #248 (4e440d3) into root (49a9d31) will increase coverage by 0.29%.
The diff coverage is 93.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #248      +/-   ##
==========================================
+ Coverage   86.36%   86.65%   +0.29%     
==========================================
  Files         113      112       -1     
  Lines        5668     5711      +43     
==========================================
+ Hits         4895     4949      +54     
+ Misses        773      762      -11     
Impacted Files Coverage Δ
ecs_composex/acm/acm_stack.py 94.44% <ø> (ø)
ecs_composex/elbv2/elbv2_ecs.py 93.00% <ø> (-0.05%) ⬇️
ecs_composex/sqs/sqs_template.py 80.28% <66.66%> (-0.55%) ⬇️
ecs_composex/dynamodb/dynamodb_template.py 76.66% <80.00%> (-2.13%) ⬇️
ecs_composex/kms/kms_template.py 73.33% <80.00%> (-1.67%) ⬇️
ecs_composex/s3/s3_stack.py 85.41% <84.61%> (+1.32%) ⬆️
ecs_composex/rds/rds_stack.py 91.17% <85.71%> (-0.50%) ⬇️
ecs_composex/common/settings.py 80.91% <86.15%> (+0.39%) ⬆️
ecs_composex/elbv2/elbv2_stack.py 87.24% <87.50%> (-1.03%) ⬇️
ecs_composex/common/compose_resources.py 88.97% <88.37%> (-0.62%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a9d31...4e440d3. Read the comment docs.

@JohnPreston
Copy link
Member Author

Deployment end-to-end tested with RDS and S3 Import

@JohnPreston JohnPreston self-assigned this Nov 12, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 0a4d258 into root Nov 12, 2020
@JohnPreston JohnPreston deleted the refactor/services-to-root-stack branch November 12, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant