Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup for ACM working #254

Merged
merged 3 commits into from
Nov 15, 2020
Merged

Lookup for ACM working #254

merged 3 commits into from
Nov 15, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston self-assigned this Nov 14, 2020
@JohnPreston JohnPreston linked an issue Nov 14, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #254 (ae540ba) into root (87ff32a) will decrease coverage by 1.75%.
The diff coverage is 88.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #254      +/-   ##
==========================================
- Coverage   88.27%   86.51%   -1.76%     
==========================================
  Files          99      119      +20     
  Lines        4358     5940    +1582     
==========================================
+ Hits         3847     5139    +1292     
- Misses        511      801     +290     
Impacted Files Coverage Δ
ecs_composex/secrets/secrets_params.py 0.00% <0.00%> (ø)
ecs_composex/vpc/vpc_maths.py 100.00% <ø> (+17.02%) ⬆️
ecs_composex/vpc/vpc_aws.py 25.00% <18.18%> (-67.23%) ⬇️
ecs_composex/vpc/vpc_stack.py 65.00% <25.00%> (-28.23%) ⬇️
ecs_composex/docdb/docdb_ecs.py 56.66% <56.66%> (ø)
ecs_composex/sns/sns_aws.py 71.42% <71.42%> (ø)
ecs_composex/dns/__init__.py 74.39% <71.87%> (-4.56%) ⬇️
ecs_composex/rds/rds_ecs.py 73.80% <73.17%> (-11.38%) ⬇️
ecs_composex/sqs/sqs_aws.py 73.17% <73.17%> (ø)
ecs_composex/kms/kms_aws.py 74.19% <74.19%> (ø)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0adc4e...ae540ba. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit dfb249c into root Nov 15, 2020
@JohnPreston JohnPreston deleted the rework/x-acm branch November 15, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-acm::MacroParameters::DnsNames
1 participant