Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes env var if Name is already set in secrets #710

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston self-assigned this Nov 14, 2023
@JohnPreston
Copy link
Member Author

@thorfi slightly different rework than your branch, should achieve the same thing.
Can you let me know if that works for you?

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit fa98419 into main Nov 15, 2023
4 of 5 checks passed
@JohnPreston JohnPreston deleted the fix/env-var-name-secrets-duplicate branch November 15, 2023 14:10
thorfi added a commit to thorfi/ecs_composex that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ECS ContainerDefinition has broken Environment entries for Secrets
1 participant