Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Listener condition #759

Merged
merged 2 commits into from
May 29, 2024
Merged

Fixing Listener condition #759

merged 2 commits into from
May 29, 2024

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston linked an issue May 28, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JohnPreston
Copy link
Member Author

@slootmaekersdirk I think the change will work for what you're trying to do. Can you please install from this branch and check that's doing what you're expecting please?

@slootmaekersdirk
Copy link

I can confirm this is working

@JohnPreston
Copy link
Member Author

JohnPreston commented May 28, 2024

I can confirm this is working

Thanks for checking. I will create a RC version and if all's good in a couple of days, will merge it :)
https://pypi.org/project/ecs_composex/1.1.3rc0/

@JohnPreston JohnPreston merged commit 6ecb774 into main May 29, 2024
4 checks passed
@JohnPreston JohnPreston deleted the fix/elbv2-lookup-no-listeners branch May 29, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] LB Lookup requires Listeners?
2 participants