Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EchoClient example #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add EchoClient example #67

wants to merge 1 commit into from

Conversation

hezhenxing
Copy link

No description provided.

@hezhenxing hezhenxing force-pushed the echoclient branch 3 times, most recently from cf858ed to b778b79 Compare April 25, 2024 01:11
@adithyaov
Copy link
Member

@hezhenxing
Thank you for the PR.
Looks like there is some problem with the CIs. I'll fix the CIs and review this.

adithyaov
adithyaov reviewed May 1, 2024
View reviewed changes
examples/EchoClient.hs Outdated Show resolved Hide resolved
adithyaov
adithyaov requested changes May 1, 2024
View reviewed changes
Copy link
Member

@adithyaov adithyaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Can you keep only the version of echo that has pipeChunks?
The two implementations are semantically different with the implementation with pipeChunk winning.

@adithyaov
Copy link
Member

Can you also rebase on the latest master?

@hezhenxing
Copy link
Author

Done as requested, please take a look.

@harendra-kumar
Copy link
Member

@adithyaov can you please merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adithyaov adithyaov adithyaov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hezhenxing @adithyaov @harendra-kumar