Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change locking API to be more object-oriented #43

Closed
computablee opened this issue Sep 23, 2023 · 7 comments
Closed

Change locking API to be more object-oriented #43

computablee opened this issue Sep 23, 2023 · 7 comments
Assignees
@HarryHeres
Labels
good first issue Good for newcomers hacktoberfest This issue is for Hacktoberfest no-parallel-programming-knowledge-necessary No parallel programming knowledge should be required to complete the issue refactor Refactor or restructure code to better align with good engineering practices
Milestone
DotMP v1.4.2

Comments

@computablee
Copy link
Owner

Currently, the locking API is in a weird transition state after merging the DotMP.Lock and DotMP.Locking classes. Right now, the way that locks are used are by instantiating a Lock object, then passing them to DotMP.Lock static methods.

This is not elegant, and locking should be accomplished by calling methods on the Lock object. I anticipate this will only be a matter of removing the static keywords from the Set, Unset, and Test methods, altering the methods to work on this._lock instead of a passed Lock object, and modifying all associated documentation (including the README).
@computablee computablee added good first issue Good for newcomers refactor Refactor or restructure code to better align with good engineering practices hacktoberfest This issue is for Hacktoberfest labels Sep 23, 2023
@computablee computablee added this to the DotMP v1.4.2 milestone Sep 23, 2023
@computablee computablee added the no-parallel-programming-knowledge-necessary No parallel programming knowledge should be required to complete the issue label Sep 23, 2023
@HarryHeres
Copy link
Contributor

Hi! I’m a CS graduate doing masters now and part of that is also a parallel programming course. Your repo seems quite interesting, got experience with Java and C++, so I believe I could be of help. Would like to start with something easier and this seems like a good fit to get into the codebase. Can I try to take care of this?

@computablee
Copy link
Owner Author

@HarryHeres sure, I'll assign you to this issue.

@HarryHeres
Copy link
Contributor

Awesome, thanks! Will try to get to this during this week

@HarryHeres
Copy link
Contributor

HarryHeres commented Oct 2, 2023 •
edited
Loading

@computablee From which branch would you like me to fork? Haven’t found any “refactor” branch.

@computablee
Copy link
Owner Author

@HarryHeres Just fork main, that will be fine.

@HarryHeres
Copy link
Contributor

Okay, thanks :)

computablee added a commit that referenced this issue Oct 3, 2023
@computablee
Merge pull request #61 from HarryHeres/43-change-locking-api
b441b43 
Updated Lock API (Issue #43)
@computablee
Copy link
Owner Author

Completed with #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarryHeres HarryHeres

Labels
good first issue Good for newcomers hacktoberfest This issue is for Hacktoberfest no-parallel-programming-knowledge-necessary No parallel programming knowledge should be required to complete the issue refactor Refactor or restructure code to better align with good engineering practices
Projects
None yet
Milestone
DotMP v1.4.2
Development

No branches or pull requests
2 participants
@computablee @HarryHeres