-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
added qcoro 0.8.0 with conan 2 support
- Loading branch information
1 parent
70bb1cd
commit 6cfd9d1
Showing
7 changed files
with
133 additions
and
42 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
recipes/qcoro/all/patches/0001-Make-how-Qt-packages-are-found-more-convinient.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
From 49b27a7dd26044a027a56fdc1247da154da3c01c Mon Sep 17 00:00:00 2001 | ||
From: Paul T <developer.paul.123@gmail.com> | ||
Date: Thu, 6 Apr 2023 15:16:41 -0400 | ||
Subject: [PATCH] Make how Qt packages are found more convinient | ||
|
||
This change allows users to specify `Qt5_DIR` or `Qt6_DIR` and then the rest of the components are automatically found. Prior to this, since `find_package()` was called for each component of Qt, CMake configuring would fail with each component not found. So you would have to specify all the paths at once. | ||
--- | ||
cmake/QCoroFindQt.cmake | 14 ++++---------- | ||
1 file changed, 4 insertions(+), 10 deletions(-) | ||
|
||
diff --git a/cmake/QCoroFindQt.cmake b/cmake/QCoroFindQt.cmake | ||
index 9bda234..9951b02 100644 | ||
--- a/cmake/QCoroFindQt.cmake | ||
+++ b/cmake/QCoroFindQt.cmake | ||
@@ -12,17 +12,11 @@ macro(qcoro_find_qt) | ||
set(ARGS_QT_VERSION 5) | ||
endif() | ||
endif() | ||
+ | ||
+ list(APPEND REQUIRED_QT_COMPONENTS "${ARGS_QT${ARGS_QT_VERSION}_COMPONENTS}") | ||
+ list(FILTER REQUIRED_QT_COMPONENTS EXCLUDE REGEX "Private$$") | ||
|
||
- foreach (component IN LISTS ARGS_COMPONENTS ARGS_QT${ARGS_QT_VERSION}_COMPONENTS) | ||
- message(STATUS "Qt component: ${component}") | ||
- if ("${component}" MATCHES "Private$$") | ||
- string(REPLACE "Private" "" base_component "${component}") | ||
- find_package(Qt${ARGS_QT_VERSION}${base_component} REQUIRED COMPONENTS Private) | ||
- else() | ||
- find_package(Qt${ARGS_QT_VERSION}${component} REQUIRED) | ||
- endif() | ||
- endforeach() | ||
+ find_package(Qt${ARGS_QT_VERSION} REQUIRED COMPONENTS ${REQUIRED_QT_COMPONENTS}) | ||
|
||
set(${ARGS_FOUND_VER_VAR} ${ARGS_QT_VERSION}) | ||
endmacro() | ||
- | ||
-- | ||
2.39.2 | ||
|
44 changes: 44 additions & 0 deletions
44
recipes/qcoro/all/patches/0002-Fix-debug-build-against-MSVC2022.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
From 1e6c27128c452a631ac486cb8f8d02d4bc1167aa Mon Sep 17 00:00:00 2001 | ||
From: Robert Griebl <robert.griebl@qt.io> | ||
Date: Mon, 6 Mar 2023 13:27:24 +0100 | ||
Subject: [PATCH] Fix debug build against MSVC2022 | ||
|
||
Due to the level-4 warnings and warnings-are-errors in debug builds, | ||
we are running into warnings in Qt's private headers and an unused | ||
warning for the "args" pack in invokeCb() | ||
--- | ||
qcoro/qcorotask.h | 2 +- | ||
qcoro/qml/qcoroqmltask.cpp | 3 +++ | ||
2 files changed, 4 insertions(+), 1 deletion(-) | ||
|
||
diff --git a/qcoro/qcorotask.h b/qcoro/qcorotask.h | ||
index 26f3e7b..1d1e87a 100644 | ||
--- a/qcoro/qcorotask.h | ||
+++ b/qcoro/qcorotask.h | ||
@@ -581,7 +581,7 @@ public: | ||
|
||
private: | ||
template<typename ThenCallback, typename ... Args> | ||
- auto invokeCb(ThenCallback &&callback, Args && ... args) { | ||
+ auto invokeCb(ThenCallback &&callback, [[maybe_unused]] Args && ... args) { | ||
if constexpr (std::is_invocable_v<ThenCallback, Args ...>) { | ||
return callback(std::forward<Args>(args) ...); | ||
} else { | ||
diff --git a/qcoro/qml/qcoroqmltask.cpp b/qcoro/qml/qcoroqmltask.cpp | ||
index 48136d6..f859cae 100644 | ||
--- a/qcoro/qml/qcoroqmltask.cpp | ||
+++ b/qcoro/qml/qcoroqmltask.cpp | ||
@@ -9,7 +9,10 @@ | ||
#include <optional> | ||
|
||
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) | ||
+QT_WARNING_PUSH | ||
+QT_WARNING_DISABLE_MSVC(4458 4201) | ||
#include <private/qjsvalue_p.h> | ||
+QT_WARNING_POP | ||
#endif | ||
|
||
Q_DECLARE_LOGGING_CATEGORY(qcoroqml) | ||
-- | ||
2.39.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
versions: | ||
"0.4.0": | ||
folder: all | ||
"0.8.0": | ||
folder: all |