Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Allow building of multiple recipes of same package in one PR #2556

Closed
madebr opened this issue Aug 16, 2020 · 5 comments
Closed

[service] Allow building of multiple recipes of same package in one PR #2556

madebr opened this issue Aug 16, 2020 · 5 comments
Assignees
Labels
infrastructure Waiting on tools or services belonging to the infra

Comments

@madebr
Copy link
Contributor

madebr commented Aug 16, 2020

Current CI does not allow changing 2 recipes for one package in one pr.

e.g. modifying:

  • recipes/zlib/1.2.8/conanfile.py
  • recipes/zlib/1.2.12/conanfile.py

in one pull request is impossible, because the CI will fail immediately.

This should become possible. It would also make maintaining recipes a lot easier

Imho, this is a high priority request, because arbitrary rules like these scare people of.

@uilianries uilianries added the infrastructure Waiting on tools or services belonging to the infra label Aug 19, 2020
@uilianries
Copy link
Member

Indeed it's annoying and as consumer I can't see the limitation because is the same project. On the other hand, as server maintainer, it requires a new feature because all current implementation involving config.yml.

/cc @danimtb

@Croydon
Copy link
Contributor

Croydon commented Aug 19, 2020

But does it really make a huge difference in the implementation? (Friendly reminder of #30)

First step is like always reading the content of config.yml and this contains the path information. And then there is probably an explicit check if those paths differ. But all of the logic afterwards can probably stay the same?

@uilianries
Copy link
Member

This is under investigation, but not in short time, because will require not an update in Jenkins, but an entire new build flow.

@ericLemanissier
Copy link
Contributor

@uilianries it already works : #22929 this issue is about building several recipes of the SAME package only

@uilianries
Copy link
Member

Sorry, I misread the "same package". I meant several recipes from different packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Waiting on tools or services belonging to the infra
Projects
None yet
Development

No branches or pull requests

5 participants