Libsndfile 1.0.29 cmake recipe #2597

MartinDelille · 2020-08-18T18:13:52Z

Specify library name and version: libsndfile/1.0.29

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

depends on

vorbis: add 1.3.7 and components #2565 vorbis
opus: fix cmake_find_package name #2604 opus
vorbis: fix cmake_find_package name #2605 flac
libsndfile: moving forlder all => pkg_config #2596 rename 1.0.28 recipe folder

Ok this is a draft but unfortunately it fails linking the library:

$ conan create . libsndfile/1.0.29@
...
Scanning dependencies of target example
[ 50%] Building CXX object CMakeFiles/example.dir/example.cpp.o
[100%] Linking CXX executable bin/example
Undefined symbols for architecture x86_64:
  "_sf_close", referenced from:
      _main in example.cpp.o
  "_sf_open", referenced from:
      _main in example.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/example] Error 1
make[1]: *** [CMakeFiles/example.dir/all] Error 2
make: *** [all] Error 2

conan-center-bot · 2020-08-18T18:14:06Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

madebr · 2020-08-18T18:23:28Z

Undefined symbols for architecture x86_64:

The error(s) you're seeing are probably caused by not using the cmake generator
(you've activated the generator, but are not using it)
See other recipes how they use it. e.g. the sophus recipe:

add a CMakeLists.txt file that includes conanbuildinfo.cmake, runs conan_basic_setup and adds the source_subdirectory subdirectory
don't forget to add this file to exports_sources
create (and configure) a CMake object in _configure_cmake and call this in build and package
set the appropriate properties in package_info. Becuase libsndfile now has cmake support, you might need to set the appropriate names (self.cpp_info.names, self.cpp_info.filenames or use components)

madebr

You will also need to add a CMakeLists.txt wrapper script (see other recipes).
Also, you will need to test this because I filled in package_info using a wild guess.

recipes/libsndfile/cmake/test_package/CMakeLists.txt

recipes/libsndfile/cmake/test_package/conanfile.py

recipes/libsndfile/cmake/conanfile.py

conan-center-bot · 2020-08-18T18:33:07Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:34:46Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:34:49Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:37:30Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/libsndfile/cmake/conanfile.py

recipes/libsndfile/cmake/test_package/conanfile.py

conan-center-bot · 2020-08-18T18:39:57Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:40:00Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:40:04Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:40:13Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T18:40:45Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T20:18:56Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-18T20:20:28Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

MartinDelille · 2020-08-18T20:25:31Z

Ok I added your proposition, fix some issue and add the requirements.

I still have link issue with the external libraries:

$. conan create . libnsdfile/1.0.29@
...

Scanning dependencies of target example
[ 50%] Building CXX object CMakeFiles/example.dir/example.cpp.o
[100%] Linking CXX executable bin/example
Undefined symbols for architecture x86_64:
  "_opus_get_version_string", referenced from:
      _ogg_opus_open in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_write_header in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_decode_float", referenced from:
      _ogg_opus_read_refill in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_decoder_create", referenced from:
      _ogg_opus_setup_decoder in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_decoder_ctl", referenced from:
      _ogg_opus_seek in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_setup_decoder in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_decoder_destroy", referenced from:
      _ogg_opus_close in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_setup_decoder in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_encode_float", referenced from:
      _ogg_opus_close in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_write_out in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_encoder_create", referenced from:
      _ogg_opus_open in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_encoder_ctl", referenced from:
      _ogg_opus_open in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_command in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_write_out in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_encoder_destroy", referenced from:
      _ogg_opus_close in libsndfile.a(ogg_opus.c.o)
  "_opus_multistream_surround_encoder_create", referenced from:
      _ogg_opus_open in libsndfile.a(ogg_opus.c.o)
  "_opus_packet_get_nb_samples", referenced from:
      _ogg_opus_open in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_seek in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_byterate in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_read_refill in libsndfile.a(ogg_opus.c.o)
  "_opus_strerror", referenced from:
      _ogg_opus_open in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_close in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_setup_decoder in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_read_refill in libsndfile.a(ogg_opus.c.o)
      _ogg_opus_write_out in libsndfile.a(ogg_opus.c.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/example] Error 1
make[1]: *** [CMakeFiles/example.dir/all] Error 2
make: *** [all] Error 2

recipes/libsndfile/all/test_package/CMakeLists.txt

recipes/libsndfile/all/conanfile.py

conan-center-bot · 2020-08-18T20:28:54Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

madebr · 2020-08-18T21:59:42Z

Please consider MartinDelille#1

And try them in combination with the packages from pull requests:

opus: opus: fix cmake_find_package name #2604
vorbis: vorbis: fix cmake_find_package name #2605
flac: flac: fix cmake_find_package name #2606

conan-center-bot · 2020-08-19T08:47:13Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

MartinDelille · 2020-08-19T08:55:07Z

Ok I merged your PR. Shall I wait #2604, #2605 and #2606 to be merged to perform this test?

madebr · 2020-08-19T15:01:49Z

Yes, the imported cmake targets were incorrect.

You will have to wait for #2565, #2604 and #2606 to have merged.
Can you add this to your first comment?

---
depends on 
- [ ] #2565 vorbis 
- [ ] #2604 opus
- [ ] #2605 flac
---

conan-center-bot · 2020-08-19T16:09:55Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-08-19T16:19:32Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

MartinDelille · 2020-09-26T10:54:12Z

@Croydon Indeed. I just rebased the pull request on master and renamed the folder to all (that will make future version like the recent 1.0.30 easy to add).

conan-center-bot · 2020-09-26T11:11:59Z

All green in build 40 (64e6fb926010277f9b7646128dda17c34f38a94d)! 😊

libsndfile/1.0.29: Generated 136 packages. All logs here

Croydon · 2020-09-29T10:08:38Z

Why wasn't this merged yet?

uilianries · 2020-09-29T17:19:44Z

@jgsogo For some reason, CCI Bot didn't merge it automatically. We have all requirements, no beta user, 3 approvals, CI result is green ... Could you please take a look?

MartinDelille · 2020-09-30T08:13:09Z

When I pass my mouse over @prince-chrismc and @madebr I read: only Only reviews by reviewer with write access count toward mergeability.

ericLemanissier · 2020-09-30T08:52:58Z

Maybe the bot waits for @Croydon to approve the PR (after having requested changes in the past) ?

jgsogo · 2020-09-30T09:07:22Z

Hello! After having a look to this one, first of all some comments:

About the number of approvals

This repo is configured in Github to require 3 approvals
@MartinDelille , yes, Github takes into account approvals ONLY from people with write access
The conan-center-bot is admin, so it can force a merge even if the PR doesn't have 3 approvals from people with write access.
conan-center-bot will merge the PR as soon as it gets 3 approvals (one of them from a team member).
If a team member requests changes, then the bot won't merge the PR even if it has more than 3 approvals from other people. (Yes, a changes requested by someone of the team is a blocker, even if it doesn't belong to the latest commit).

About the approvals:

We are using the Github API to retrieve the approvals: https://api.github.com/repos/conan-io/conan-center-index/pulls/2597/reviews (see next comment), and we take into account the reviews that correspond to the latest commit in the PR (64e6fb926010277f9b7646128dda17c34f38a94d). As you can see in the JSON only reviews by madebr and prince-chrismc are associated with the latest commit. Reviews by @uilianries and @SSE4 are associated with other commits. This is what the bot is taking into account:

Reviews summary for PR #2597:
 - prince-chrismc: APPROVED
 - madebr: APPROVED
[Pipeline] echo
Blockers (any commit): croydon
[Pipeline] echo
APPROVALS: team (0), community (2)

Having a closer look to the Github API response:

Review by @SSE4 doesn't show up, does it belong to a commit that was removed from this branch?
All reviews by @uilianries are comments or are dismissed... does the green review by @uilianries belong to a removed commit?

I really don't know why Github is not showing all the reviews properly, any ideas related to the history of commits/reviews in this PR?

jgsogo · 2020-09-30T09:20:27Z

I'm copying here the API output, as it is now: https://api.github.com/repos/conan-io/conan-center-index/pulls/2597/reviews

[
  {
    "id": 469714977,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDY5NzE0OTc3",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "You will also need to add a `CMakeLists.txt` wrapper script (see other recipes).\r\nAlso, you will need to test this because I filled in `package_info` using a wild guess.",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469714977",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469714977"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-08-18T18:29:28Z",
    "commit_id": "e50004ea305154134c7a950b272341aeb40bc6c4"
  },
  {
    "id": 469724570,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDY5NzI0NTcw",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469724570",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469724570"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-08-18T18:38:25Z",
    "commit_id": "95fde4ebbc8ff5dd9b3498de6f3136fe7e9dc57d"
  },
  {
    "id": 469725489,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDY5NzI1NDg5",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469725489",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469725489"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-08-18T18:39:33Z",
    "commit_id": "95fde4ebbc8ff5dd9b3498de6f3136fe7e9dc57d"
  },
  {
    "id": 469804298,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDY5ODA0Mjk4",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469804298",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-469804298"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-08-18T20:27:59Z",
    "commit_id": "ae71cdf7c5daa79a122dc04882850c3b25c95024"
  },
  {
    "id": 478678440,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDc4Njc4NDQw",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-478678440",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-478678440"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-08-31T14:44:00Z",
    "commit_id": "24e334d94c8be09ed973b7cfb398184a4e8fd4d8"
  },
  {
    "id": 482134053,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDgyMTM0MDUz",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-482134053",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-482134053"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-03T19:19:35Z",
    "commit_id": "4451f630193e4177424c2b7a6e1f94e524abb6af"
  },
  {
    "id": 485734374,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg1NzM0Mzc0",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-485734374",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-485734374"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-10T09:08:38Z",
    "commit_id": "b5d8f51bd5473ac27f6bbe9165cae70f279a258a"
  },
  {
    "id": 485734800,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg1NzM0ODAw",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-485734800",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-485734800"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-10T09:09:09Z",
    "commit_id": "b5d8f51bd5473ac27f6bbe9165cae70f279a258a"
  },
  {
    "id": 485789035,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg1Nzg5MDM1",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-485789035",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-485789035"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-10T10:19:34Z",
    "commit_id": "b63f99a688dab207c97d41ad70deb0920d8146b9"
  },
  {
    "id": 486137753,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg2MTM3NzUz",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-486137753",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-486137753"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-10T17:02:55Z",
    "commit_id": "ce205071df8e7f4b262d8d9f61d1a6eddb962559"
  },
  {
    "id": 486139609,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg2MTM5NjA5",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-486139609",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-486139609"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-10T17:05:31Z",
    "commit_id": "ce205071df8e7f4b262d8d9f61d1a6eddb962559"
  },
  {
    "id": 486140101,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg2MTQwMTAx",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-486140101",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-486140101"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-10T17:06:13Z",
    "commit_id": "ce205071df8e7f4b262d8d9f61d1a6eddb962559"
  },
  {
    "id": 487538757,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg3NTM4NzU3",
    "user": {
      "login": "ericLemanissier",
      "id": 1926390,
      "node_id": "MDQ6VXNlcjE5MjYzOTA=",
      "avatar_url": "https://avatars1.githubusercontent.com/u/1926390?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/ericLemanissier",
      "html_url": "https://github.com/ericLemanissier",
      "followers_url": "https://api.github.com/users/ericLemanissier/followers",
      "following_url": "https://api.github.com/users/ericLemanissier/following{/other_user}",
      "gists_url": "https://api.github.com/users/ericLemanissier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/ericLemanissier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/ericLemanissier/subscriptions",
      "organizations_url": "https://api.github.com/users/ericLemanissier/orgs",
      "repos_url": "https://api.github.com/users/ericLemanissier/repos",
      "events_url": "https://api.github.com/users/ericLemanissier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/ericLemanissier/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-487538757",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-487538757"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-14T08:40:02Z",
    "commit_id": "93c415795678b18d7540d22d8adce8026b9bf473"
  },
  {
    "id": 487696180,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg3Njk2MTgw",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-487696180",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-487696180"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-14T12:21:44Z",
    "commit_id": "93c415795678b18d7540d22d8adce8026b9bf473"
  },
  {
    "id": 487713552,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg3NzEzNTUy",
    "user": {
      "login": "ericLemanissier",
      "id": 1926390,
      "node_id": "MDQ6VXNlcjE5MjYzOTA=",
      "avatar_url": "https://avatars1.githubusercontent.com/u/1926390?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/ericLemanissier",
      "html_url": "https://github.com/ericLemanissier",
      "followers_url": "https://api.github.com/users/ericLemanissier/followers",
      "following_url": "https://api.github.com/users/ericLemanissier/following{/other_user}",
      "gists_url": "https://api.github.com/users/ericLemanissier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/ericLemanissier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/ericLemanissier/subscriptions",
      "organizations_url": "https://api.github.com/users/ericLemanissier/orgs",
      "repos_url": "https://api.github.com/users/ericLemanissier/repos",
      "events_url": "https://api.github.com/users/ericLemanissier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/ericLemanissier/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-487713552",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-487713552"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-14T12:44:01Z",
    "commit_id": "93c415795678b18d7540d22d8adce8026b9bf473"
  },
  {
    "id": 488551830,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg4NTUxODMw",
    "user": {
      "login": "MartinDelille",
      "id": 879889,
      "node_id": "MDQ6VXNlcjg3OTg4OQ==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/879889?u=761c94575f8fcd761921da1e8843e8438380d838&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/MartinDelille",
      "html_url": "https://github.com/MartinDelille",
      "followers_url": "https://api.github.com/users/MartinDelille/followers",
      "following_url": "https://api.github.com/users/MartinDelille/following{/other_user}",
      "gists_url": "https://api.github.com/users/MartinDelille/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/MartinDelille/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/MartinDelille/subscriptions",
      "organizations_url": "https://api.github.com/users/MartinDelille/orgs",
      "repos_url": "https://api.github.com/users/MartinDelille/repos",
      "events_url": "https://api.github.com/users/MartinDelille/events{/privacy}",
      "received_events_url": "https://api.github.com/users/MartinDelille/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-488551830",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-488551830"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-15T10:41:05Z",
    "commit_id": "ad105fa82c965d9ef11fd3af1d5290a958acdfc2"
  },
  {
    "id": 488711618,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg4NzExNjE4",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-488711618",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-488711618"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-15T13:57:01Z",
    "commit_id": "ad105fa82c965d9ef11fd3af1d5290a958acdfc2"
  },
  {
    "id": 489940196,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg5OTQwMTk2",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-489940196",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-489940196"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-16T19:04:17Z",
    "commit_id": "ad105fa82c965d9ef11fd3af1d5290a958acdfc2"
  },
  {
    "id": 489944299,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg5OTQ0Mjk5",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "DISMISSED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-489944299",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-489944299"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-16T19:10:22Z",
    "commit_id": "ad105fa82c965d9ef11fd3af1d5290a958acdfc2"
  },
  {
    "id": 489942942,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDg5OTQyOTQy",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-489942942",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-489942942"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-16T19:11:48Z",
    "commit_id": "ad105fa82c965d9ef11fd3af1d5290a958acdfc2"
  },
  {
    "id": 490702419,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkwNzAyNDE5",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-490702419",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-490702419"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-17T15:08:59Z",
    "commit_id": "a9b62d024859630c48ffdc91f3dcd2cfb9f11ad6"
  },
  {
    "id": 490702547,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkwNzAyNTQ3",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-490702547",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-490702547"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-17T15:09:07Z",
    "commit_id": "a9b62d024859630c48ffdc91f3dcd2cfb9f11ad6"
  },
  {
    "id": 490975542,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkwOTc1NTQy",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-490975542",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-490975542"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-17T20:45:03Z",
    "commit_id": "a9b62d024859630c48ffdc91f3dcd2cfb9f11ad6"
  },
  {
    "id": 491753040,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkxNzUzMDQw",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-491753040",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-491753040"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-18T20:12:25Z",
    "commit_id": "3d2da6f381a6449e0ba0a0ca1aee181760585ea7"
  },
  {
    "id": 491852532,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkxODUyNTMy",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-491852532",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-491852532"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-19T02:00:28Z",
    "commit_id": "3d2da6f381a6449e0ba0a0ca1aee181760585ea7"
  },
  {
    "id": 492012620,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkyMDEyNjIw",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "DISMISSED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-492012620",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-492012620"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-19T17:27:11Z",
    "commit_id": "f6d87868c144eacfdcfb975a84ade87fc9d94bde"
  },
  {
    "id": 493658172,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDkzNjU4MTcy",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "DISMISSED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-493658172",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-493658172"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-22T16:46:16Z",
    "commit_id": "f6d87868c144eacfdcfb975a84ade87fc9d94bde"
  },
  {
    "id": 495153257,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDk1MTUzMjU3",
    "user": {
      "login": "Croydon",
      "id": 1593194,
      "node_id": "MDQ6VXNlcjE1OTMxOTQ=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/1593194?u=bf4858503d312309c9ed63035dc4cb98321def78&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/Croydon",
      "html_url": "https://github.com/Croydon",
      "followers_url": "https://api.github.com/users/Croydon/followers",
      "following_url": "https://api.github.com/users/Croydon/following{/other_user}",
      "gists_url": "https://api.github.com/users/Croydon/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/Croydon/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/Croydon/subscriptions",
      "organizations_url": "https://api.github.com/users/Croydon/orgs",
      "repos_url": "https://api.github.com/users/Croydon/repos",
      "events_url": "https://api.github.com/users/Croydon/events{/privacy}",
      "received_events_url": "https://api.github.com/users/Croydon/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "As said in https://github.com/conan-io/conan-center-index/pull/2596#issuecomment-6756530 the recipe folder should be renamed to `all`",
    "state": "CHANGES_REQUESTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-495153257",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-495153257"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-24T01:04:02Z",
    "commit_id": "f6d87868c144eacfdcfb975a84ade87fc9d94bde"
  },
  {
    "id": 497675589,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDk3Njc1NTg5",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16867443?u=7220989afe6305a20cb2bd37d816f94f15f5ab97&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "APPROVED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-497675589",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-497675589"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-28T15:59:05Z",
    "commit_id": "64e6fb926010277f9b7646128dda17c34f38a94d"
  },
  {
    "id": 497685425,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDk3Njg1NDI1",
    "user": {
      "login": "madebr",
      "id": 4138939,
      "node_id": "MDQ6VXNlcjQxMzg5Mzk=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4138939?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/madebr",
      "html_url": "https://github.com/madebr",
      "followers_url": "https://api.github.com/users/madebr/followers",
      "following_url": "https://api.github.com/users/madebr/following{/other_user}",
      "gists_url": "https://api.github.com/users/madebr/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/madebr/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/madebr/subscriptions",
      "organizations_url": "https://api.github.com/users/madebr/orgs",
      "repos_url": "https://api.github.com/users/madebr/repos",
      "events_url": "https://api.github.com/users/madebr/events{/privacy}",
      "received_events_url": "https://api.github.com/users/madebr/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "APPROVED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-497685425",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/2597#pullrequestreview-497685425"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/2597"
      }
    },
    "submitted_at": "2020-09-28T16:10:20Z",
    "commit_id": "64e6fb926010277f9b7646128dda17c34f38a94d"
  }
]

ericLemanissier · 2020-09-30T09:22:51Z

There is a problem with github API, because @SSE4 , @uilianries and your (@jgsogo ) review all happenned after the last push from @MartinDelille

jgsogo · 2020-09-30T09:25:41Z

Yes, my approval is not shown in the API either... 😕

Oh! https://www.githubstatus.com/ API requests are under maintenance, let's wait a little bit to see what happens after the maintenance

MartinDelille · 2020-09-30T10:06:59Z

API request is green again on https://www.githubstatus.com/

jgsogo · 2020-09-30T11:09:33Z

Looks like the API response is not updated with (at least) my review which does belong to the latest commit for sure. Maybe it is just a matter of time and eventually they will achieve congruency among the different databases (the one for the UI and the one for the API requests)... We can come back to this PR as see the response from https://api.github.com/repos/conan-io/conan-center-index/pulls/2597/reviews, meanwhile I'm merging it manually.

Sorry for the inconvenience. I'm afraid other PRs might be affected by this same issue :/

conan-center-bot added the No Beta user label Aug 18, 2020

MartinDelille mentioned this pull request Aug 18, 2020

[package] libsndfile/1.0.28: Invalid configuration for Windows #2491

Closed

madebr reviewed Aug 18, 2020

View reviewed changes

recipes/libsndfile/cmake/conanfile.py Outdated Show resolved Hide resolved

recipes/libsndfile/cmake/conanfile.py Outdated Show resolved Hide resolved

madebr reviewed Aug 18, 2020

View reviewed changes

recipes/libsndfile/cmake/test_package/conanfile.py Outdated Show resolved Hide resolved

MartinDelille force-pushed the libsndfile-cmake branch from 1cf214c to fa424f6 Compare August 18, 2020 20:18

MartinDelille force-pushed the libsndfile-cmake branch from fa424f6 to ae71cdf Compare August 18, 2020 20:20

madebr reviewed Aug 18, 2020

View reviewed changes

recipes/libsndfile/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

recipes/libsndfile/all/conanfile.py Outdated Show resolved Hide resolved

MartinDelille force-pushed the libsndfile-cmake branch from ae71cdf to 96fb18b Compare August 18, 2020 20:28

MartinDelille and others added 8 commits September 26, 2020 12:51

Update recipes/libsndfile/1.0.29/conanfile.py

0cd65d2

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Update recipes/libsndfile/1.0.29/conanfile.py

462c83c

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Update recipes/libsndfile/1.0.29/conanfile.py

725f92e

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Update recipes/libsndfile/1.0.29/conanfile.py

b063dd8

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Update recipes/libsndfile/1.0.29/conanfile.py

3b599b6

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Apply suggestions from code review

f7d2f6c

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Apply suggestions from code review

d411f63

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Folder 1.0.29 => all

64e6fb9

MartinDelille dismissed stale reviews from uilianries and prince-chrismc via 64e6fb9 September 26, 2020 10:51

MartinDelille force-pushed the libsndfile-cmake branch from f6d8786 to 64e6fb9 Compare September 26, 2020 10:51

prince-chrismc approved these changes Sep 28, 2020

View reviewed changes

madebr approved these changes Sep 28, 2020

View reviewed changes

uilianries approved these changes Sep 28, 2020

View reviewed changes

SSE4 approved these changes Sep 29, 2020

View reviewed changes

jgsogo approved these changes Sep 30, 2020

View reviewed changes

jgsogo merged commit a53039f into conan-io:master Sep 30, 2020

MartinDelille deleted the libsndfile-cmake branch July 15, 2021 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Libsndfile 1.0.29 cmake recipe #2597

Libsndfile 1.0.29 cmake recipe #2597

MartinDelille commented Aug 18, 2020 •

edited

Loading

conan-center-bot commented Aug 18, 2020

madebr commented Aug 18, 2020

madebr left a comment

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

MartinDelille commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

madebr commented Aug 18, 2020

conan-center-bot commented Aug 19, 2020

MartinDelille commented Aug 19, 2020

madebr commented Aug 19, 2020

conan-center-bot commented Aug 19, 2020

conan-center-bot commented Aug 19, 2020

MartinDelille commented Sep 26, 2020

conan-center-bot commented Sep 26, 2020

Croydon commented Sep 29, 2020

uilianries commented Sep 29, 2020

MartinDelille commented Sep 30, 2020

ericLemanissier commented Sep 30, 2020

jgsogo commented Sep 30, 2020 •

edited

Loading

jgsogo commented Sep 30, 2020

ericLemanissier commented Sep 30, 2020

jgsogo commented Sep 30, 2020

MartinDelille commented Sep 30, 2020

jgsogo commented Sep 30, 2020

Libsndfile 1.0.29 cmake recipe #2597

Libsndfile 1.0.29 cmake recipe #2597

Conversation

MartinDelille commented Aug 18, 2020 • edited Loading

conan-center-bot commented Aug 18, 2020

madebr commented Aug 18, 2020

madebr left a comment

Choose a reason for hiding this comment

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

MartinDelille commented Aug 18, 2020

conan-center-bot commented Aug 18, 2020

madebr commented Aug 18, 2020

conan-center-bot commented Aug 19, 2020

MartinDelille commented Aug 19, 2020

madebr commented Aug 19, 2020

conan-center-bot commented Aug 19, 2020

conan-center-bot commented Aug 19, 2020

MartinDelille commented Sep 26, 2020

conan-center-bot commented Sep 26, 2020

Croydon commented Sep 29, 2020

uilianries commented Sep 29, 2020

MartinDelille commented Sep 30, 2020

ericLemanissier commented Sep 30, 2020

jgsogo commented Sep 30, 2020 • edited Loading

About the number of approvals

About the approvals:

jgsogo commented Sep 30, 2020

ericLemanissier commented Sep 30, 2020

jgsogo commented Sep 30, 2020

MartinDelille commented Sep 30, 2020

jgsogo commented Sep 30, 2020

MartinDelille commented Aug 18, 2020 •

edited

Loading

jgsogo commented Sep 30, 2020 •

edited

Loading