Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg/system: Modernize #11698

Merged

Conversation

jwillikers
Copy link
Contributor

Use tools.system.package_manager ang tools.gnu.PkgConfig from the conan namespace.
This greatly reduces complexity of the package.

Specify library name and version: xorg/system

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericLemanissier

This comment was marked as outdated.

recipes/xorg/all/conanfile.py Outdated Show resolved Hide resolved
recipes/xorg/all/conanfile.py Show resolved Hide resolved
recipes/xorg/all/conanfile.py Outdated Show resolved Hide resolved
@ericLemanissier

This comment was marked as outdated.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

please, don't force-push, it prevents from doing incremental reviews

Sorry about that, I wasn't aware.

@jwillikers
Copy link
Contributor Author

jwillikers commented Jul 15, 2022

  1. This fails on FreeBSD with a lot of ld: error: unable to find library -lxcb when linking the test package cf https://github.com/bincrafters/system-packages-checks/runs/7356617446?check_suite_focus=true#step:3:17496. These libraries have properly been installed above. Is the library path propagated ?

Most likely /usr/local/lib is not in the default linker search path?

  1. This fails on debian 10 with dpkg-query: no packages found matching libxcb-util-dev and dpkg-query: no packages found matching libxcb-util0-dev https://github.com/bincrafters/system-packages-checks/runs/7356633944?check_suite_focus=true#step:6:814

Hopefully the changes to the substitutes method have fixed this.

  1. alma linux fails with ERROR: while executing system_requirements(): Error 100 while executing yum check-update -y This has to be solved in conan
No match for argument: libfontenc-devel
No match for argument: libXdmcp-devel
No match for argument: libxkbfile-devel
No match for argument: libXres-devel
No match for argument: libXvMC-devel
No match for argument: xorg-x11-xtrans-devel
No match for argument: xcb-util-wm-devel
No match for argument: xcb-util-image-devel
No match for argument: xcb-util-keysyms-devel
No match for argument: xcb-util-renderutil-devel
No match for argument: xcb-util-devel

Looks like the -devel versions of the library aren't available in Alma Linux. How should we handle this? We could use the substitutes method with an empty list, but maybe xorg/system should just fail with an error at that point?

  1. fedora, opensuse and centos don't install any package. You have to add DNF handling to this PR

Added explicit DNF support.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericLemanissier

This comment was marked as outdated.

@ericLemanissier
Copy link
Contributor

@jgsogo @danimtb is there a plan to add tools.system.package_manager:mode=install config on C3I ?

@ghost
Copy link

ghost commented Jul 20, 2022

I detected other pull requests that are modifying xorg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@jgsogo
Copy link
Contributor

jgsogo commented Jul 20, 2022

@jgsogo @danimtb is there a plan to add tools.system.package_manager:mode=install config on C3I ?

I guess this is the equivalent in v2 to conan config set general.sysrequires_mode=enabled, right?

@ericLemanissier
Copy link
Contributor

yes : https://docs.conan.io/en/latest/reference/conanfile/tools/system/package_manager.html#configuration-properties-that-affect-how-system-package-managers-are-invoked
The difference is that it can be set in:

  • global.conf
  • the profile
  • the commande line with -c

@ericLemanissier
Copy link
Contributor

ericLemanissier commented Jul 22, 2022

@jwillikers it seems it should work now https://github.com/conan-io/conan-center-index/pull/11859/files#diff-77f023b99d3d58008351d3e82fc06e6d06ba1bc2da9e41be6329b7fa4f419f05R10
Can you close/reopen ?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

jwillikers commented Jul 22, 2022

@jwillikers it seems it should work now https://github.com/conan-io/conan-center-index/pull/11859/files#diff-77f023b99d3d58008351d3e82fc06e6d06ba1bc2da9e41be6329b7fa4f419f05R10 Can you close/reopen ?

Sorry, had to rebase and force push. Nothing has actually changed in the PR.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Jul 23, 2022
4 tasks
Use tools.system.package_manager ang tools.gnu.PkgConfig from the `conan` namespace.
This greatly reduces complexity of the package.
This fixes linking against xorg libraries on FreeBSD.
On FreeBSD, Pkg installs the libraries in /usr/local/lib.
This is not a system library directory.
Therefore, the libraries must not be treated as system libraries.
This links the libraries according to their full paths.
@conan-center-bot
Copy link
Collaborator

All green in build 10 (2ffbcf0203d1fb34c2916b8fbe203c1c1b2c7191):

  • xorg/system@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants