Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2 version 2.24.0 #12186

Merged
merged 33 commits into from
Sep 3, 2022
Merged

sdl2 version 2.24.0 #12186

merged 33 commits into from
Sep 3, 2022

Conversation

paulocoutinhox
Copy link
Contributor

@paulocoutinhox paulocoutinhox commented Aug 12, 2022

Specify library name and version: sdl/2.24.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

Release:
https://github.com/libsdl-org/SDL/releases/tag/release-2.24.0

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Aug 12, 2022
@paulocoutinhox
Copy link
Contributor Author

Trying to fix:
libsdl-org/SDL#6040

@paulocoutinhox
Copy link
Contributor Author

Android problems only was fixed in the next SDL2 release:
libsdl-org/SDL#6040

@paulocoutinhox
Copy link
Contributor Author

@conan-center-bot

This comment has been minimized.

@paulocoutinhox
Copy link
Contributor Author

paulocoutinhox commented Aug 12, 2022

Anyone knows what can be wrong here?

cputype does not match previous archive members cputype

I put on SDL github too:

libsdl-org/SDL#6041

@madebr
Copy link
Contributor

madebr commented Aug 13, 2022

@paulocoutinhox
I'm continuing here as I think is an issue with c3i instead of sdl.
I think you can enable verbose building by setting the verbose attribute on the CMake object:

cmake.verbose = True

To speed up builds, you might want to exclude all non-Macos builds from the build matrix by doing:

def validate(self):
    if self.settings.os != "Macos":
        raise ConanInvalidConfiguration("Excluded for reasons")

@paulocoutinhox
Copy link
Contributor Author

paulocoutinhox commented Aug 14, 2022

@madebr
I change on recipe conanfile or test_package conanfile?

@madebr
Copy link
Contributor

madebr commented Aug 14, 2022

It's the SDL build that is failing, so the main recipe.

@paulocoutinhox
Copy link
Contributor Author

It's the SDL build that is failing, so the main recipe.

Done

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor

madebr commented Aug 14, 2022

So the configuration armv8@Macis is troublesome.

From what I understand now, the errors happens when running ranlib.
What I find strange about the offending command is that it does not contain any architecture related argument.

/Applications/conan/xcode/12/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib ../lib/libSDL2.a

The errors:

./lib/libSDL2.a(SDL_nullvideo.c.o) cputype (16777228) does not match previous archive members cputype (16777223) (all members must match)

says: "I got an object file for arch=arm64 but I expected arch=x86_64".
This means ranlib has wrong arguments.

Sadly, there are no logs available for previous sdl versions.
Can you remove 2.0.22 from config.yml and configdata.yml?
Then we can compare and see whether this is a regression with sdl's cmake script or with c3i.

@paulocoutinhox
Copy link
Contributor Author

paulocoutinhox commented Aug 15, 2022

The command line executed is:

[ 95%] Building C object source_subfolder/CMakeFiles/SDL2-static.dir/src/video/cocoa/SDL_cocoawindow.m.o
cd /Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/sdl/2.0.22/_/_/build/1a51b3c2bef48f2ff0b3b07f7f42471608784267/build_subfolder/source_subfolder && /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -DUSING_GENERATED_CONFIG_H -I/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/sdl/2.0.22/_/_/build/1a51b3c2bef48f2ff0b3b07f7f42471608784267/build_subfolder/source_subfolder/include -I/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/libiconv/1.17/_/_/package/8fafab5ebfba468fd21a497cfee65cafe294bd9e/include -I/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/sdl/2.0.22/_/_/build/1a51b3c2bef48f2ff0b3b07f7f42471608784267/source_subfolder/include -idirafter "/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/sdl/2.0.22/_/_/build/1a51b3c2bef48f2ff0b3b07f7f42471608784267/source_subfolder/src/video/khronos" -D_THREAD_SAFE -Wshadow -fvisibility=hidden -Wdeclaration-after-statement -Werror=declaration-after-statement -fno-strict-aliasing -Wall  -O3 -DNDEBUG  -arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -fPIC -MD -MT source_subfolder/CMakeFiles/SDL2-static.dir/src/video/cocoa/SDL_cocoawindow.m.o -MF CMakeFiles/SDL2-static.dir/src/video/cocoa/SDL_cocoawindow.m.o.d -o CMakeFiles/SDL2-static.dir/src/video/cocoa/SDL_cocoawindow.m.o -c /Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/sdl/2.0.22/_/_/build/1a51b3c2bef48f2ff0b3b07f7f42471608784267/source_subfolder/src/video/cocoa/SDL_cocoawindow.m

It is compiling for -arch arm64 on macos sdk. Probably that is a M1 machine:

Configuration (profile_host):
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
[options]
sdl:shared=False
[build_requires]
[env]
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True
tools.apple:sdk_path=/Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk

Configuration (profile_build):
[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
[options]
sdl:shared=False
[build_requires]
[env]
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True
tools.apple:sdk_path=/Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk

@madebr And about config, i remove what you sad.

@conan-center-bot

This comment has been minimized.

recipes/sdl/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Hooks produced the following warnings for commit d2be641
sdl/2.0.16
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
sdl/2.0.14
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.

recipes/sdl/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Hooks produced the following warnings for commit 417f598
sdl/2.24.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl/2.0.18
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl/2.0.20
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
sdl/2.0.16
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl/2.0.14
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.

@paulocoutinhox
Copy link
Contributor Author

Finally! huauhahua

madebr
madebr previously approved these changes Sep 1, 2022
Copy link
Contributor

@madebr madebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best. SDL2. Release. Ever. 😉

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@paulocoutinhox Please, consider https://github.com/paulocoutinhox/conan-center-index/pull/5. The Conan v2 linter is not happy.

@paulocoutinhox
Copy link
Contributor Author

@paulocoutinhox Please, consider paulocoutinhox#5. The Conan v2 linter is not happy.

sure, done and thanks!

@conan-center-bot
Copy link
Collaborator

All green in build 31 (7f94fe272ecdd0807ec214d7155a8c7aeec29284):

  • sdl/2.0.20@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • sdl/2.0.16@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • sdl/2.24.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • sdl/2.0.14@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • sdl/2.0.18@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12186/recipes/sdl/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Hooks produced the following warnings for commit 7f94fe2
sdl/2.0.20
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl/2.0.16
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl/2.24.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
sdl/2.0.14
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl/2.0.18
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.

@paulocoutinhox
Copy link
Contributor Author

Hi @uilianries and @madebr there is some warning. It is relevant?

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0d.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2-2.0.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.

@madebr
Copy link
Contributor

madebr commented Sep 2, 2022

Hi @uilianries and @madebr there is some warning. It is relevant?

For the latest sdl2 release at least, you can add them (when building a static library): https://github.com/libsdl-org/SDL/blob/253f6a913d232e536e092756732f41b78175d862/CMakeLists.txt#L2145-L2180
Of course, check whether the conan recipe has options to enable/disable these frameworks.

@paulocoutinhox
Copy link
Contributor Author

We can keep this as-it because is working. And open an issue/pr if it really need after.

@conan-center-bot conan-center-bot merged commit 4e8eca4 into conan-io:master Sep 3, 2022
@paulocoutinhox paulocoutinhox deleted the sdl2-2-0-22 branch September 3, 2022 05:45
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 26, 2022
* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* Update recipes/sdl/all/CMakeLists.txt

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Update recipes/sdl/all/CMakeLists.txt

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Update recipes/sdl/all/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Update recipes/sdl/all/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Update recipes/sdl/all/conandata.yml

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* sdl2 version 2.0.22

* update sdl to 2.24.0

* sdl2 version 2.24.0

* Update recipes/sdl/all/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Update recipes/sdl/all/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* update recipes/sdl/all/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* sdl2 version 2.24.0

* sdl2 version 2.24.0

* sdl2 version 2.24.0

* sdl2 version 2.24.0

* sdl2 version 2.24.0

* sdl2 version 2.24.0

* Update conan tools imports

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants