odbc: conan v2 support + unvendor libltdl #13131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Weird, there are ODR violations in test_package but not in test_v1_package... And only with clang 12 on Linux, not clang 11 for example. |
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Sep 26, 2022
This was referenced Sep 27, 2022
Merged
|
I detected other pull requests that are modifying odbc/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
ghost
mentioned this pull request
jgsogo
previously approved these changes
Sep 28, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
approved these changes
Sep 29, 2022
prince-chrismc
approved these changes
Sep 29, 2022
| - patch_file: "patches/missing-declarations.patch" | ||
| base_path: "source_subfolder" | ||
| - patch_file: "patches/0001-duplicated-get-connection.patch" | ||
| - patch_file: "patches/0002-missing-declarations.patch" |
| for patch in self.conan_data.get("patches", {}).get(self.version, []): | ||
| tools.patch(**patch) | ||
| apply_conandata_patches(self) | ||
| # support more triplets | ||
| shutil.copy(self._user_info_build["gnu-config"].CONFIG_SUB, |
There was a problem hiding this comment.
The new tools.copy it does not so dummy like self.copy:
https://docs.conan.io/en/latest/reference/conanfile/tools/files/basic.html#conan-tools-files-copy
There was a problem hiding this comment.
Ideal the Conan api should be doing file io tools.files api
System-Arch
pushed a commit
to System-Arch/conan-center-index
that referenced
this pull request
Oct 7, 2022
* conan v2 support * handle system libs deps of libltdl * fix ODR violation between odbc & odbccr * fix duplicated symbol in 2.3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!