[libiconv] conan v2 update #13263
[libiconv] conan v2 update #13263
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Pretty sure this counts towards #12888 |
This comment has been minimized.
This comment has been minimized.
recipes/libiconv/all/conanfile.py
Outdated
| env.define("NM", "dumpbin -symbols") | ||
| env.define("win32_target", "_WIN32_WINNT_VISTA") | ||
|
|
||
| if is_msvc(self) and Version(self.settings.compiler.version) >= "12": |
There was a problem hiding this comment.
This isn't going to work correctly for the msvc compiler, only Visual Studio. Unfortunately, there won't be a more helpful solution until Conan 1.53.0 for this: conan-io/conan#11158
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
This comment has been minimized.
This comment has been minimized.
| env = VirtualBuildEnv(self) | ||
| env.generate() |
There was a problem hiding this comment.
should be called before AutotoolsToolchain, otherwise it can defeat msvc env var tricks above.
There was a problem hiding this comment.
@SpaceIm @uilianries this is still called after AutotoolsToolchain,
can this recipe be fixed up to be done the "proper" way?
I am trying to use this recipe as a model for upgrading libsodium, and its not good if this recipe isn't "gold standard" (or suggests another to follow)
There was a problem hiding this comment.
Actually, how does this even work properly? "env" variable name is reused...
first as env = tc.environment() and then as env=VirtualBuildEnv(self).
how should it be done "before AutotoolsToolchain" ?
There was a problem hiding this comment.
Use the paclage templates as a refernce point, https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/autotools_package/all/conanfile.py#L91
we are trying to focus on keeping those up to spec
|
|
||
| def source(self): | ||
| tools.get(**self.conan_data["sources"][self.version], destination=self._source_subfolder, strip_root=True) | ||
| def generate(self): |
There was a problem hiding this comment.
would be nice to move this after source(), otherwise recipe execution flow is a little bit confusing
* [libiconv] update to v2 toolchain * [libiconv] update test packages vor v2 * [libiconv] fix cross building check * [libiconv] supply '-FS' flag for msvc debug * [libiconv] add destination to source method * Update recipes/libiconv/all/test_v1_package/CMakeLists.txt Co-authored-by: Jordan Williams <jordan@jwillikers.com> * [libiconv] handle msvc compiler version Co-authored-by: Jordan Williams <jordan@jwillikers.com>
Specify library name and version: libiconv
Conan v2 and toolchain updates