-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib: several fixes & improvements #13440
glib: several fixes & improvements #13440
Conversation
I detected other pull requests that are modifying glib/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Issue in |
def generate(self): | ||
|
||
env = VirtualBuildEnv(self) | ||
env.generate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see it used anywhere... why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there are build requirements. My understanding is that it's implicit in conan v2 mode, but not in conan v1 mode by default.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8a1036b
to
154d0c2
Compare
This comment has been minimized.
This comment has been minimized.
033a05c
to
b65fb36
Compare
All green in build 8 (
|
Hooks produced the following warnings for commit b65fb36glib/2.68.3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rpath
)compiler=msvc
as well