Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#13463) zlib: Bump to 1.2.13 #13464

Merged
merged 3 commits into from
Oct 14, 2022
Merged

(#13463) zlib: Bump to 1.2.13 #13464

merged 3 commits into from
Oct 14, 2022

Conversation

miklelappo
Copy link
Contributor

@miklelappo miklelappo commented Oct 14, 2022 •
edited
Loading

Especially important to fix CVE 2022 37434

Specify library name and version: zlib/1.2.13

Changes in 1.2.13 (13 Oct 2022)
- Fix configure issue that discarded provided CC definition
- Correct incorrect inputs provided to the CRC functions
- Repair prototypes and exporting of new CRC functions
- Fix inflateBack to detect invalid input with distances too far
- Have infback() deliver all of the available output up to any error
- Fix a bug when getting a gzip header extra field with inflate()
- Fix bug in block type selection when Z_FIXED used
- Tighten deflateBound bounds
- Remove deleted assembler code references
- Various portability and appearance improvements

madler/zlib#686

Closes #13463

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Oct 14, 2022

I detected other pull requests that are modifying zlib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Oct 14, 2022
Closed
Merged
@conan-center-bot

This comment has been minimized.

Sign in to view
@miklelappo
(conan-io#13463) zlib: Bump to 1.2.13
2c601e3 
Especially important to fix CVE 2022 37434
@conan-center-bot conan-center-bot added Bump version PR bumping version without recipe modifications and removed Failed labels Oct 14, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added Unexpected Error Bump version PR bumping version without recipe modifications and removed Unexpected Error Bump version PR bumping version without recipe modifications labels Oct 14, 2022
mlappo
mlappo previously approved these changes Oct 14, 2022
View reviewed changes
antonkesy
antonkesy previously approved these changes Oct 14, 2022
View reviewed changes
@miklelappo
Copy link
Contributor Author

CI wakeup

@miklelappo miklelappo closed this Oct 14, 2022
@miklelappo miklelappo reopened this Oct 14, 2022
@conan-center-bot conan-center-bot added Bump version PR bumping version without recipe modifications and removed Bump version PR bumping version without recipe modifications labels Oct 14, 2022
@miklelappo
Copy link
Contributor Author

Wake CI

@miklelappo miklelappo closed this Oct 14, 2022
@miklelappo miklelappo reopened this Oct 14, 2022
@conan-center-bot conan-center-bot added Bump version PR bumping version without recipe modifications and removed Bump version PR bumping version without recipe modifications labels Oct 14, 2022
@miklelappo miklelappo requested review from antonkesy and SpaceIm and removed request for SpaceIm and antonkesy October 14, 2022 11:39
@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label Oct 14, 2022
antonkesy
antonkesy previously approved these changes Oct 14, 2022
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 14, 2022
Open
@miklelappo miklelappo requested a review from SpaceIm October 14, 2022 14:33
@prince-chrismc
Copy link
Contributor

@miklelappo do not spam open and close.

The service has a backlog and you need to be more patient.

Be patient.

@miklelappo
Copy link
Contributor Author

Ok :-) I had an impression with previous patch that this worked out after 24 hours waiting in backlog

@conan-center-bot
Copy link
Collaborator

All green in build 8 (3bbcd4f499d9a2bd35120a78fe10bc4bc73db724):

  • zlib/1.2.12@:
    All packages built successfully! (All logs)

  • zlib/1.2.11@:
    All packages built successfully! (All logs)

  • zlib/1.2.13@:
    All packages built successfully! (All logs)

@uilianries
Copy link
Member

@miklelappo For every close/open, a new build is created, but it's added as last job to be executed in the queue. So even if you do it several times, you will need to wait until your turn.

@miklelappo
Copy link
Contributor Author

@uilianries , @prince-chrismc I see. No problem. I think today the builds are way faster than few dazs ago

@conan-center-bot conan-center-bot merged commit 7f9fdc9 into conan-io:master Oct 14, 2022
@prince-chrismc
Copy link
Contributor

I think today the builds are way faster than few dazs ago

There are 50% more workers where it was slow! I am really happy to hear it's noticeable improvement!

@miklelappo
Copy link
Contributor Author

@prince-chrismc definitely noticeable :-) 29 hours for previous PR vs 3 hours (for the last retry) this time :-) And also protobuf PR went through today #13471 in just some hours

@prince-chrismc
Copy link
Contributor

For reference about how got that actually is

prince-chrismc/conan-center-index-pending-review#1

graph

@Neustradamus
Copy link

@miklelappo: Good job!

Cogitri pushed a commit to dampsoft/conan-center-index that referenced this pull request Nov 2, 2022
@miklelappo @Cogitri
(conan-io#13464) (conan-io#13463) zlib: Bump to 1.2.13
b7dc348 
* (conan-io#13463) zlib: Bump to 1.2.13

Especially important to fix CVE 2022 37434

* Rebase Fix-Cmake patch

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlappo mlappo mlappo approved these changes

@antonkesy antonkesy antonkesy approved these changes

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

@SpaceIm SpaceIm Awaiting requested review from SpaceIm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] zlib/1.2.13
9 participants
@miklelappo @conan-center-bot @prince-chrismc @uilianries @Neustradamus @jwillikers @antonkesy @SpaceIm @mlappo