Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli11: conan v2 support #13793

Merged
merged 5 commits into from
Oct 31, 2022
Merged

cli11: conan v2 support #13793

merged 5 commits into from
Oct 31, 2022

Conversation

paulharris
Copy link
Contributor

A header-only library!
I haven't done one for v2 before, not sure if I should leave the call to cmake.build() in there.

@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only small comments.

recipes/cli11/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/cli11/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/cli11/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/cli11/all/conanfile.py Outdated Show resolved Hide resolved
@paulharris @uilianries
Apply suggestions from code review
dc7f6e3 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
uilianries
uilianries previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

Sign in to view
jwillikers
jwillikers previously approved these changes Oct 28, 2022
View reviewed changes
recipes/cli11/all/test_package/conanfile.py Outdated Show resolved Hide resolved
@uilianries uilianries self-requested a review October 28, 2022 15:35
@prince-chrismc
Copy link
Contributor

#12888 This was an easy one I was saving 🙈

great work

prince-chrismc
prince-chrismc previously approved these changes Oct 28, 2022
View reviewed changes
@prince-chrismc
Copy link
Contributor

😕 not sure why it failed.. might be worth merging master back into you branch to sync it up

[Pipeline] End of Pipeline
hudson.remoting.ProxyException: Assertion failed: 

assert parentCommits[1] == masterCommit

@paulharris @toge
Update recipes/cli11/all/test_v1_package/CMakeLists.txt
1293631 
Co-authored-by: toge <toge.mail@gmail.com>
@paulharris
Copy link
Contributor Author

#12888 This was an easy one I was saving see_no_evil

great work

whoops, well you can always re-do it for your seminar?
Maybe add a column in that list for which ones people want to take?
I've got my own list (you've seen it) that I was working through...

@conan-center-bot

This comment has been minimized.

Sign in to view
@paulharris
Copy link
Contributor Author

Sorry guys, I've applied the suggested changes and merged with master as per @prince-chrismc suggestion.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 7 (35119cfd8315260eb44953db5dcea2619f7ef1d0):

  • cli11/2.2.0@:
    All packages built successfully! (All logs)

  • cli11/2.1.2@:
    All packages built successfully! (All logs)

  • cli11/1.9.1@:
    All packages built successfully! (All logs)

  • cli11/2.3.0@:
    All packages built successfully! (All logs)

  • cli11/2.1.1@:
    All packages built successfully! (All logs)

  • cli11/2.0.0@:
    All packages built successfully! (All logs)

@prince-chrismc
Copy link
Contributor

whoops, well you can always re-do it for your seminar?

I actually have more registration then I thought so there will be people on duplicates 🙈 as long as the list(s) gets done we are happy campers

@conan-center-bot conan-center-bot merged commit 2fc42d1 into conan-io:master Oct 31, 2022
@prince-chrismc prince-chrismc mentioned this pull request Oct 31, 2022
Closed
@paulharris paulharris deleted the cli11-conan-v2 branch November 2, 2022 05:44
@samuel-emrys samuel-emrys mentioned this pull request Jun 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toge toge toge left review comments

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paulharris @conan-center-bot @prince-chrismc @toge @uilianries @jwillikers