Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highfive: add v2.5.1 and v2.6.2 #13988

Merged
merged 5 commits into from
Nov 25, 2022
Merged

highfive: add v2.5.1 and v2.6.2 #13988

merged 5 commits into from
Nov 25, 2022

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Nov 3, 2022 •
edited
Loading

Specify library name and version: highfive/2.x.x

Add version 2.5.1 and 2.6.2

  • I've read the guidelines for contributing.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Nov 3, 2022
Open
@robomics robomics mentioned this pull request Nov 3, 2022
Closed
@robomics robomics changed the title highfive: bump version highfive: add v2.5.0 Nov 3, 2022
@conan-center-bot conan-center-bot added Bump version PR bumping version without recipe modifications Failed labels Nov 3, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 3, 2022
Open
Closed
@robomics
Copy link
Contributor Author

robomics commented Nov 3, 2022

Need to wait for #13992.

@robomics
Copy link
Contributor Author

I noticed that v2.5.1, v2.6.0 and v2.6.1 are now available.

Once #13992 is merged, I am thinking of pushing a commit to drop v2.5.0 and add v2.5.1 and v2.6.1.

@robomics
Copy link
Contributor Author

robomics commented Nov 16, 2022 •
edited
Loading

@uilianries I think I am a bit in a loop due to mismatches in zlib versions.

Now that #13992 has been merged, boost and hdf5 both require zlib 1.2.13, while opencv still requires zlib 1.2.12.

Bumping zlib to 1.2.13 for opencv leads to the following warnings on my machine (which I suspect would cause Conan's CI to fail)

WARN: libpng/1.6.37: requirement zlib/1.2.12 overridden by opencv/2.4.13.7 to zlib/1.2.13
WARN: openexr/2.5.7: requirement zlib/1.2.12 overridden by opencv/2.4.13.7 to zlib/1.2.13
WARN: libtiff/4.3.0: requirement zlib/1.2.12 overridden by opencv/2.4.13.7 to zlib/1.2.13
WARN: libtiff/4.3.0: requirement libjpeg/9e overridden by opencv/2.4.13.7 to libjpeg/9d

Should we maybe consider changing the default for highfive.witn_opencv to be False?

This was referenced Nov 18, 2022
Closed
Closed
@ghost
Copy link

ghost commented Nov 18, 2022

I detected other pull requests that are modifying highfive/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@robomics robomics changed the title highfive: add v2.5.0 highfive: add v2.5.1 and v2.6.1 Nov 18, 2022
@conan-center-bot conan-center-bot removed Failed Bump version PR bumping version without recipe modifications labels Nov 18, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 18, 2022
Closed
Closed
@prince-chrismc
Copy link
Contributor

It looks like you local conan cache is a touch stale #13905 should already be fix for instance

@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc pushed a commit to prince-chrismc/conan-center-index that referenced this pull request Nov 19, 2022
jasper: Bump dependencies
097504e 
Needed for conan-io#13988 and conan-io#14281
@prince-chrismc prince-chrismc mentioned this pull request Nov 19, 2022
Merged
4 tasks
prince-chrismc
prince-chrismc reviewed Nov 22, 2022
View reviewed changes
recipes/highfive/all/conanfile.py
@@ -27,7 +27,7 @@ class HighFiveConan(ConanFile):
"with_boost": True,
"with_eigen": True,
"with_xtensor": True,
"with_opencv": True,
"with_opencv": False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was holding off since we usually dont change these but this matches upstream https://github.com/BlueBrain/HighFive/blob/577a2552357ddd9ba9ed412452ea5406747033b4/CMakeLists.txt#L23

So it's acceptable to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the opencv/jaspar deps issue.
I can submit another PR once #13159 is solved to set with_opencv back to True.

prince-chrismc
prince-chrismc previously approved these changes Nov 22, 2022
View reviewed changes
@robomics robomics changed the title highfive: add v2.5.1 and v2.6.1 highfive: add v2.5.1 and v2.6.2 Nov 23, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 7 (1fd9b4aec325b27d268c89e942ec443d2e398b24):

  • highfive/2.5.1@:
    All packages built successfully! (All logs)

  • highfive/2.3.1@:
    All packages built successfully! (All logs)

  • highfive/2.4.1@:
    All packages built successfully! (All logs)

  • highfive/2.6.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 0c3eb23 into conan-io:master Nov 25, 2022
conan-center-bot pushed a commit that referenced this pull request Dec 2, 2022
@prince-chrismc @SpaceIm
(#14291) jasper: Bump dependencies + update imports
dfa430b 
* jasper: Bump dependencies

Needed for #13988 and #14281

* block failing config + update imports

* fix extra del

* tix typo

* update save to new helper

* Update recipes/jasper/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robomics @conan-center-bot @prince-chrismc @uilianries