-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm 10.0.0 #1450
llvm 10.0.0 #1450
Conversation
This comment has been minimized.
This comment has been minimized.
WHAT I don't know what that means, I literally copied the config from my previous |
You need to rename |
It started building on Visual Studio but I stopped the build because I did not have enough free space and it required a lot of CPU power (which impeded my other work). I noticed that it requires Z3, so I opened #1451 |
Ouch.... Thank you |
I would love to monitor how many resources this build consumes in the CI 😅 This is going to be huge, let's work on those dependencies 🙌 Note.- We'll try to improve that error message, but it won't be the highest priority right now |
It will be great if you can list the dependencies of the subprojects you know, like openmp. I will change the recipe to use conandata.yml to list the projects and its deps (to keep the recipe clean) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
if self.settings.compiler == "Visual Studio" and Version(self.settings.compiler.version) < "19.1": | ||
raise ConanInvalidConfiguration("Need MSVC >= 19.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're too restrictive. Visual Studio 2017 is version 15.
(see the generator section of cmake --help
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, see the previous build error:
CMake Error at cmake/modules/CheckCompilerVersion.cmake:38 (message):
Host Visual Studio version must be at least 19.1, your version is
19.0.24215.1.
Call Stack (most recent call first):
cmake/modules/CheckCompilerVersion.cmake:51 (check_compiler_version)
cmake/config-ix.cmake:13 (include)
CMakeLists.txt:623 (include)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19.0.24215.1 is the version of the C compiler, not the version of visual studio.
Look at personal your conan settings file: $HOME/.conan/settings.yml
.
There exists no Visual Studio compiler whose version >= 19.1.
Or check https://en.wikipedia.org/wiki/Microsoft_Visual_Studio#2019.
Visual Studio 2019 => version 16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So host Visual Studio version 16.4 and lower is known to miscompile part of LLVM.
- That means only up-to-date versions of visual studio 2019 can build llvm.
- This also means that the test in
configure
must compare against themajor.minor
version of MSVC (16.4) instead of onlymajor
(16).
Hehe, conan-center-index policies do not allow usage of root llvm project with their documented CMake modules (Which is what you find in 99% of tutorials). So one more +1 to my previous comment :P |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Manu343726 |
This comment has been minimized.
This comment has been minimized.
Anything that I can do to help this pass, as I would like very much to use libclang on windows / mac? |
I detected other pull requests that are modifying llvm/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Michael Keck <git@cr0ydon.com>
Co-authored-by: Michael Keck <git@cr0ydon.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failure in build 2 ( An unexpected error happened and has been reported. Help is on its way! 🏇 |
We are currently not prioritising packages that add toolchains (rather than libraries or pure executables), as we are prioritising other issues in our backlog. LLVM itself has a myriad of components, and I suspect different users would have different needs. We are opening this issue to track this: #23834 - actual uses cases with examples will help the team gain better insights at how a potential llvm recipe may be used, whether or not it is worth packaging different LLVM components in separate recipes, and so on. Any information of this would be appreciated in that issue so that we can move forward, thanks! |
Specify library name and version: llvm/10.0.0
conan-center hook activated.
Related to #683
This PR implements a llvm recipe by using current llvm source structure on github.
All llvm projects are now maintained under the same git repository, with a
LLVM_ENABLE_PROJECTS
CMake option to enable the different projects. I have listed all (Including openmp @jgsogo) and mapped them
to package options (clang and compiler-rt are enabled by default, but we can discuss this).
The package includes The official LLVM frontend tutorial as
test_package/
.Note the package has no dependencies, but we know llvm has some external dependencies (
libtinfo
) that are not currently available inconan-center-index
.After talking with @jgsogo I have decided to push this recipe as a first version we can continue working with. I haven't had time to test
the recipe on Windows, but I'm sure it should be working since the recipe does nothing special and just calls the llvm cmake with the documented
configuration. Anyway, I will be glad if someone could test it for me.