[symengine] conan v2 support #14872
Merged
[symengine] conan v2 support #14872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit cbbb24esymengine/0.8.1symengine/0.9.0 |
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Dec 27, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@uilianries are any more changes needed here? |
cqc-alec
requested review from
prince-chrismc
and removed request for
uilianries
uilianries
approved these changes
Jan 27, 2023
|
|
||
| def generate(self): | ||
| tc = CMakeToolchain(self) | ||
| tc.variables["CMAKE_CXX_STANDARD"] = "11" |
There was a problem hiding this comment.
Usually we set it directly in the cmake file with target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_11) But no problem using here instead.
| find_package(symengine REQUIRED CONFIG) | ||
|
|
||
| add_executable(${PROJECT_NAME} test_package.cpp) | ||
| target_link_libraries(${PROJECT_NAME} PRIVATE symengine::symengine) # FIXME: Replace `symengine::symengine` with `symengine` |
There was a problem hiding this comment.
FIXME: Replace
symengine::symenginewithsymengine
It would need a new module in the recipe, but no problem skipping it for now.
prince-chrismc
approved these changes
Jan 28, 2023
1 task
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* [symengine] conan v2 support * Remove unused import. * Relax conan version requirement. * Restore old `test_package` directory renamed to `test_v1_package`. * Remove files unwanted for packaging. * Search for files recursively. * Restore line accidentally missed out. * Specify C++11 in test package. * Add "m" to system libs on Linux. * Use latest boost version. * Format with black. * Set CMAKE_CXX_STANDARD using CMakeToolChain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: symengine/0.9.0