Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plf_list: add version 2.57, support apple-clang 14 #15453

Merged
merged 3 commits into from
Feb 1, 2023
Merged

plf_list: add version 2.57, support apple-clang 14 #15453

merged 3 commits into from
Feb 1, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Jan 24, 2023

Specify library name and version: plf_list/*

  • add version 2.57
  • plf_list >= 2.50 doesn't support apple-clang 14 because apple-clang 14 defaults C++20
  • use add_subdirectory in test_v1_package

@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Open
SpaceIm
SpaceIm reviewed Jan 24, 2023
View reviewed changes
recipes/plf_list/all/conanfile.py Outdated
Comment on lines 33 to 37
if Version(self.version) >= "2.50":
replace_in_file(self, os.path.join(self.source_folder, "plf_list.h"),
"if __cplusplus > 201704L && ((defined(_LIBCPP_VERSION) && _LIBCPP_VERSION >= 13) || !defined(_LIBCPP_VERSION)) && ((defined(__clang__) && (__clang_major__ >= 13)) || (defined(__GNUC__) && __GNUC__ >= 10) || (!defined(__clang__) && !defined(__GNUC__)))",
"if __cplusplus > 201704L && ((defined(_LIBCPP_VERSION) && _LIBCPP_VERSION >= 13) || !defined(_LIBCPP_VERSION)) && (!defined(__APPLE_CC__) && (defined(__clang__) && (__clang_major__ >= 13)) || (defined(__GNUC__) && __GNUC__ >= 10) || (!defined(__clang__) && !defined(__GNUC__)))"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no_copy_source must be removed if there is a patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm
I missed it.
Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move this to a patch file please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm
I agree with you.
Let me try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jan 28, 2023
Merged
1 task
uilianries
uilianries approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

Sign in to view
@toge toge closed this Feb 1, 2023
@toge toge reopened this Feb 1, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (5b2020df6dec9c52a22684b4f47d823f59dfe8a0):

  • plf_list/2.52@:
    All packages built successfully! (All logs)

  • plf_list/2.50@:
    All packages built successfully! (All logs)

  • plf_list/2.03@:
    All packages built successfully! (All logs)

  • plf_list/2.57@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 4 (5b2020df6dec9c52a22684b4f47d823f59dfe8a0):

  • plf_list/2.50@:
    All packages built successfully! (All logs)

  • plf_list/2.57@:
    All packages built successfully! (All logs)

  • plf_list/2.03@:
    All packages built successfully! (All logs)

  • plf_list/2.52@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 6a27935 into conan-io:master Feb 1, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@toge @StellaSmith
(conan-io#15453) plf_list: add version 2.57, support apple-clang 14
5d49b83 
* plf_list: add version 2.57, support apple-clang 14

* remove no_copy_source

* create patch files for apple-clang 14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toge @conan-center-bot @uilianries @jwillikers @SpaceIm