-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linter workflow: fix linter change test on test_package #15500
Conversation
this should fix the error message counting
it's also now faster to run. |
take advantage of the faster execution time
There is a permissions issue
For review, the last summary generated by this PR: https://github.com/conan-io/conan-center-index/actions/runs/4035760268#summary-10955058022 |
in future, I would love to move script/logic outside of the YAML (as it's a format for data, not for code). |
@danimtb @prince-chrismc What do you think of this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't be worse then already broken :)
* linter workflow: randomize the test of linter changes * do a single pylint call for all tests this should fix the error message counting * sort messages by order of occurance * Update linter-conan-v2.yml * test 500 recipes take advantage of the faster execution time * post result as message on PR * fixup * Update linter-conan-v2.yml * Update linter-conan-v2.yml * Update linter-conan-v2.yml * Remove message posting There is a permissions issue
it has been broken by #15005
the error was
broken runs:
Instead of taking the 250 first recipes in alphabetical order, use
shuf
to randomize the selectionAlso, fix the grouping of error messages, and order by decreasing occurance