Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-ares: add version 1.19.0 #15523

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Jan 29, 2023

Specify library name and version: c-ares/*

  • add version 1.19.0
  • add patch description
  • use add_subdirectory in test_v1_package
  • format conandata.yml

Try to close #15564.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit b123371
c-ares/1.15.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcares.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
c-ares/1.14.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcares.so' links to system library 'nsl' but it is not in cpp_info.system_libs.

jwillikers
jwillikers previously approved these changes Jan 30, 2023
mlappo
mlappo previously approved these changes Jan 30, 2023
Copy link

@mlappo mlappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 9 to 22
url: "https://github.com/c-ares/c-ares/archive/refs/tags/cares-1_17_2.tar.gz"
sha256: "444b7dbf33cb6e8a764d069e3485cbaaa28386d60eace6988275c3cb9534d300"
"1.17.1":
sha256: 61f7cf09605f5e38d4828f82d0e2ddb9de8e355ecfd6819b740691c644583b8f
url: https://github.com/c-ares/c-ares/archive/cares-1_17_1.tar.gz
url: "https://github.com/c-ares/c-ares/archive/cares-1_17_1.tar.gz"
sha256: "61f7cf09605f5e38d4828f82d0e2ddb9de8e355ecfd6819b740691c644583b8f"
"1.16.1":
sha256: 870962cc8f6b352303c404ce848e2ea1f1072f3c0a940042209a72179511c08c
url: https://github.com/c-ares/c-ares/archive/cares-1_16_1.tar.gz
url: "https://github.com/c-ares/c-ares/archive/cares-1_16_1.tar.gz"
sha256: "870962cc8f6b352303c404ce848e2ea1f1072f3c0a940042209a72179511c08c"
"1.15.0":
sha256: 7deb7872cbd876c29036d5f37e30c4cbc3cc068d59d8b749ef85bb0736649f04
url: https://github.com/c-ares/c-ares/archive/cares-1_15_0.tar.gz
url: "https://github.com/c-ares/c-ares/archive/cares-1_15_0.tar.gz"
sha256: "7deb7872cbd876c29036d5f37e30c4cbc3cc068d59d8b749ef85bb0736649f04"
"1.14.0":
sha256: 62dd12f0557918f89ad6f5b759f0bf4727174ae9979499f5452c02be38d9d3e8
url: https://github.com/c-ares/c-ares/archive/cares-1_14_0.tar.gz
url: "https://github.com/c-ares/c-ares/archive/cares-1_14_0.tar.gz"
sha256: "62dd12f0557918f89ad6f5b759f0bf4727174ae9979499f5452c02be38d9d3e8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to take advantage of this modification to point to official tarballs (as already done for 1.18.1 & 1.19.0)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm
Thanks a lot!
I modified urls.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just one url to fix: #15523 (comment)

@toge toge dismissed stale reviews from mlappo and jwillikers via cec27b2 January 31, 2023 19:20
jwillikers
jwillikers previously approved these changes Jan 31, 2023
Comment on lines 14 to 16
"1.16.1":
sha256: 870962cc8f6b352303c404ce848e2ea1f1072f3c0a940042209a72179511c08c
url: https://github.com/c-ares/c-ares/archive/cares-1_16_1.tar.gz
url: "https://github.com/c-ares/c-ares/releases/download/cares-1_16_0/c-ares-1.16.0.tar.gz"
sha256: "de058ad7c128156e2db6dc98b8a359924d6f210a1b99dd36ba15c8f839a83a89"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm
Sorry for my miss.
Fixed.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (07849068ad28405a20537163ce6da5446a902273):

  • c-ares/1.19.0@:
    All packages built successfully! (All logs)

  • c-ares/1.18.1@:
    All packages built successfully! (All logs)

  • c-ares/1.17.2@:
    All packages built successfully! (All logs)

  • c-ares/1.17.1@:
    All packages built successfully! (All logs)

  • c-ares/1.16.1@:
    All packages built successfully! (All logs)

  • c-ares/1.15.0@:
    All packages built successfully! (All logs)

  • c-ares/1.14.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 5 (07849068ad28405a20537163ce6da5446a902273):

  • c-ares/1.19.0@:
    Error running command conan graph info --requires c-ares/1.19.0@#a166f059d875b8eedd10b2efe9aa67a9 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/3fa1829a-0a72-436e-9fbb-597c10a110fb/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/3fa1829a-0a72-436e-9fbb-597c10a110fb/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.19.0: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    
  • c-ares/1.18.1@:
    Error running command conan graph info --requires c-ares/1.18.1@#c88bae59343c20f4baaff0301f9205f2 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/e025a6e0-0d76-412b-8842-2d6669cbd460/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/e025a6e0-0d76-412b-8842-2d6669cbd460/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.18.1: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    
  • c-ares/1.17.2@:
    Error running command conan graph info --requires c-ares/1.17.2@#063b310ee3d6c6fca850e80a1eabce42 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/9e592a9b-4378-46a1-88e9-82c1e9778716/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/9e592a9b-4378-46a1-88e9-82c1e9778716/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.17.2: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    
  • c-ares/1.17.1@:
    Error running command conan graph info --requires c-ares/1.17.1@#c9b3c6ca860845a37adb7708bd71d3cf -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/dce6ea93-e048-4408-9e47-61d7f4a20ae4/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/dce6ea93-e048-4408-9e47-61d7f4a20ae4/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.17.1: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    
  • c-ares/1.16.1@:
    Error running command conan graph info --requires c-ares/1.16.1@#3a2e93abd4814531f997da7cb4fa9674 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/aee92d28-16d1-495b-becc-e27d07515aac/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/aee92d28-16d1-495b-becc-e27d07515aac/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.16.1: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    
  • c-ares/1.14.0@:
    Error running command conan graph info --requires c-ares/1.14.0@#4e8088f0b65c7423bb20dafef5489d1d -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/eb6365fb-830e-4c1d-b805-c83411bf5eaf/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/eb6365fb-830e-4c1d-b805-c83411bf5eaf/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.14.0: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    
  • c-ares/1.15.0@:
    Error running command conan graph info --requires c-ares/1.15.0@#b4050513ee6dc8c0df413bfdd8df07e8 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15523/5/ac23ccec-efa4-47fd-8b76-55f883b2e1d9/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt -pr:b /home/conan/w/prod-v2_cci_PR-15523/5/ac23ccec-efa4-47fd-8b76-55f883b2e1d9/profile_windows_192_release_dynamic_msvc_release_64.-shared-True.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    
    -------- Computing dependency graph --------
    ERROR: c-ares/1.15.0: Error in configure() method, line 41
    	del self.options.fPIC
    	ConanException: option 'fPIC' doesn't exist
    Possible options are ['shared', 'tools']
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Hooks produced the following warnings for commit 0784906
c-ares/1.15.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcares.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
c-ares/1.14.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcares.so' links to system library 'nsl' but it is not in cpp_info.system_libs.

Copy link
Contributor

@miklelappo miklelappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit a9c92c6 into conan-io:master Feb 1, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* c-ares: add version 1.19.0

* add end line

* use official tarballs

* fix url for 1.16.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] c-ares/1.19.0
7 participants