qt5: fix some Android and iOS errors #15539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I detected other pull requests that are modifying qt/5.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Jan 29, 2023
1 task
| @@ -0,0 +1,19 @@ | |||
| diff --git a/src/corelib/global/qlogging.cpp b/src/corelib/global/qlogging.cpp | |||
There was a problem hiding this comment.
Do you have have a link to an issue on bugreports.qt.io or to a patch on codereview.qt-project.org?
This level of android api should supported out of the box https://doc.qt.io/qt-5/android.html
There was a problem hiding this comment.
unfortunately, no such issue has been raised yet. I've also checked backports in https://invent.kde.org/qt/qt/qtbase/-/commits/kde/5.15 but there's also no such fix.
according to https://doc.qt.io/qt-5/android-getting-started.html Qt 5.15 has been tested only with NDK 20b and 21, pretty sure those toolchain versions don't have backtrace functions or execinfo.h.
I only found https://bugreports.qt.io/browse/QTBUG-108054 but that applies to Qt 6 only, and the patch can't be applied to Qt 5 because of heavy changes that Qt 6 made.
There was a problem hiding this comment.
ok, thanks for the clarifications
|
also added fix for #15536 |
ericLemanissier
previously approved these changes
Jan 30, 2023
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 7215c14qt/5.15.8 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 7215c14qt/5.15.6 |
|
I guess windows builders run out of space. Should I still keep playing the "close+reopen PR" game or better wait for a day? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ericLemanissier would it be fine if I add changes from #15471 to this PR to have less stuff to build for CI? |
|
yes |
prince-chrismc
added
the
infrastructure
|
@jcar87 can you please put this on the list for the team. There's a disk space problem |
This was referenced Apr 6, 2023
Merged
|
This should fail with version conflicts since I see other QT PRs have startign building 🤞 |
|
Scheduling project: prod » BuildSingleReference GitHub has been notified of this commit’s build result Finished: FAILURE |
|
It's working on windows 🤞 |
conan-center-bot
removed
Failed
infrastructure
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3639383qt/5.15.8qt/5.15.6qt/5.15.7qt/5.15.5 |
|
finally green! @prince-chrismc thanks a lot! @ericLemanissier could you review? |
ericLemanissier
approved these changes
Apr 12, 2023
prince-chrismc
approved these changes
Apr 12, 2023
This comment has been minimized.
This comment has been minimized.
|
It's working on linux clang still 🤞 |
Conan v1 pipeline ✔️All green in build 21 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 23 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 3639383qt/5.15.6qt/5.15.8qt/5.15.5qt/5.15.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: qt/5.15.x
CROSS_COMPILEoption isn't required for Android according to https://doc.qt.io/qt-5/android-building.htmlexecinfo.h.