Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argtable3: add version 3.2.2, support conan v2 #15548

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Jan 30, 2023

Specify library name and version: argtable3/*

  • add version 3.2.2
  • support conan v2
  • add patch description

@conan-center-bot

This comment has been minimized.

@danimtb
Copy link
Member

danimtb commented Jan 30, 2023

@toge thanks for the PR! Please, review the annotations made by the linter and the report of conan v2 pipeline. It seems that those things could be easily improved in this PR. Thank you 😄

@toge
Copy link
Contributor Author

toge commented Jan 31, 2023

@danimtb
I see.
I will try.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (60450e61b496a10c4e856da553faf5034acf5282):

  • argtable3/3.2.2@:
    All packages built successfully! (All logs)

  • argtable3/3.2.1@:
    All packages built successfully! (All logs)

  • argtable3/3.2.0@:
    All packages built successfully! (All logs)

  • argtable3/3.1.5@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 2 (60450e61b496a10c4e856da553faf5034acf5282):

  • argtable3/3.2.2@:
    Didn't run or was cancelled before finishing

  • argtable3/3.2.0@:
    Didn't run or was cancelled before finishing

  • argtable3/3.2.1@:
    CI failed to create some packages (All logs)

    Logs for packageID b647c43bfefae3f830561ca202b6cfd935b56205:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
        argtable3/3.2.1#2081e44bdf0eee9566b66cb068da349c:b647c43bfefae3f830561ca202b6cfd935b56205#b4112d5395d782a52e68fd5c85a62a66 - Cache
    
    -------- test_package: Installing packages --------
    
    -------- Installing (downloading, building) binaries... --------
    argtable3/3.2.1: Already installed!
    WARN: The use of 'cpp_info.filenames' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    WARN: The use of 'cpp_info.filenames' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    WARN: The use of 'cpp_info.build_modules' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    WARN: The use of 'cpp_info.build_modules' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    
    -------- Testing the package --------
    argtable3/3.2.1 (test package): Writing generators to /home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release/generators
    argtable3/3.2.1 (test package): Generator 'CMakeDeps' calling 'generate()'
    argtable3/3.2.1 (test package): Generator 'CMakeToolchain' calling 'generate()'
    argtable3/3.2.1 (test package): Preset 'release' added to CMakePresets.json. Invoke it manually using 'cmake --preset release'
    argtable3/3.2.1 (test package): If your CMake version is not compatible with CMakePresets (<3.19) call cmake like: 'cmake <path> -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release/generators/conan_toolchain.cmake -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_BUILD_TYPE=Release'
    argtable3/3.2.1 (test package): Generator 'VirtualRunEnv' calling 'generate()'
    argtable3/3.2.1 (test package): Aggregating env generators
    
    -------- Testing the package: Building --------
    argtable3/3.2.1 (test package): Calling build()
    argtable3/3.2.1 (test package): CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/."
    argtable3/3.2.1 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/."
    -- Using Conan toolchain: /home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release/generators/conan_toolchain.cmake
    -- The C compiler identification is GNU 11.1.0
    -- Check for working C compiler: /usr/local/bin/cc
    -- Check for working C compiler: /usr/local/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Conan: Target declared 'argtable3'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release
    argtable3/3.2.1 (test package): CMake command: cmake --build "/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release" -- -j3
    argtable3/3.2.1 (test package): RUN: cmake --build "/home/conan/w/prod-v2/BuildSingleReference/conan-center-index/recipes/argtable3/all/test_package/test_output/build/Release" -- -j3
    Scanning dependencies of target test_package
    [ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
    [100%] Linking C executable test_package
    [100%] Built target test_package
    
    -------- Testing the package: Running test() --------
    argtable3/3.2.1 (test package): Running test()
    ERROR: argtable3/3.2.1 (test package): Error in test() method, line 25
    	self.run(f"{bin_path} --help", run_environment=True)
    	TypeError: run() got an unexpected keyword argument 'run_environment'
    
  • argtable3/3.1.5@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 3701df1 into conan-io:master Feb 3, 2023
self.cpp_info.system_libs.append("m")

self.cpp_info.set_property("cmake_file_name", "Argtable3")
self.cpp_info.set_property("cmake_target_name", "argtable3")
Copy link
Contributor

@SpaceIm SpaceIm Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's incorrect, there is a comment in this recipe explaining what are official target names:

These targets were for versions <= 3.2.0 (newer create argtable3::argtable3)

sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
* argtable3: add version 3.2.2, support conan v2

* fix conan v2 linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants