-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argtable3: add version 3.2.2, support conan v2 #15548
Conversation
This comment has been minimized.
This comment has been minimized.
@toge thanks for the PR! Please, review the annotations made by the linter and the report of conan v2 pipeline. It seems that those things could be easily improved in this PR. Thank you 😄 |
@danimtb |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
self.cpp_info.system_libs.append("m") | ||
|
||
self.cpp_info.set_property("cmake_file_name", "Argtable3") | ||
self.cpp_info.set_property("cmake_target_name", "argtable3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's incorrect, there is a comment in this recipe explaining what are official target names:
These targets were for versions <= 3.2.0 (newer create argtable3::argtable3)
* argtable3: add version 3.2.2, support conan v2 * fix conan v2 linter errors
Specify library name and version: argtable3/*