Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log4cplus: add version 2.0.8, support conan v2 #15549

Merged
merged 6 commits into from
Feb 9, 2023
Merged

log4cplus: add version 2.0.8, support conan v2 #15549

merged 6 commits into from
Feb 9, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Jan 30, 2023

Specify library name and version: log4cplus/*

  • add version 2.0.8
  • support conan v2
  • update libiconv

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jan 30, 2023
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 898d7bb
log4cplus/2.0.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblog4cplus.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
log4cplus/2.0.6 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblog4cplus.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
log4cplus/2.0.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblog4cplus.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
log4cplus/2.0.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblog4cplus.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
log4cplus/2.0.8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblog4cplus.so' links to system library 'nsl' but it is not in cpp_info.system_libs.

@github-actions github-actions bot mentioned this pull request Jan 31, 2023
Open
uilianries
uilianries previously approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prince-chrismc prince-chrismc mentioned this pull request Feb 1, 2023
Merged
1 task
@toge toge closed this Feb 3, 2023
@toge toge reopened this Feb 3, 2023
jwillikers
jwillikers previously approved these changes Feb 3, 2023
View reviewed changes
SpaceIm
SpaceIm reviewed Feb 3, 2023
View reviewed changes
recipes/log4cplus/all/conandata.yml Outdated
"2.0.6":
- patch_file: "patches/2.0.6-0001-fix-cmake.patch"
patch_description: "disable fPIC, move cmake_minimum_version to front"
patch_type: "backport"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
patch_type: "backport"
patch_type: "conan"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for all other patches

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm
Thank you.
Fixed.

@toge toge dismissed stale reviews from jwillikers and uilianries via 2cfce4b February 3, 2023 15:21
@toge @SpaceIm
fix properties
e5922ce 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (e5922ceb0aa0e6645968550a1efece7ee83faa85):

  • log4cplus/2.0.7@:
    All packages built successfully! (All logs)

  • log4cplus/2.0.4@:
    All packages built successfully! (All logs)

  • log4cplus/2.0.5@:
    All packages built successfully! (All logs)

  • log4cplus/2.0.6@:
    All packages built successfully! (All logs)

  • log4cplus/2.0.8@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 10 (e5922ceb0aa0e6645968550a1efece7ee83faa85):

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot conan-center-bot merged commit 89fecc3 into conan-io:master Feb 9, 2023
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
@toge @SpaceIm @sabelka
(conan-io#15549) log4cplus: add version 2.0.8, support conan v2
fcc20eb 
* log4cplus: add version 2.0.8, support conan v2

* remove cmake verbose makefile

* move cmake_minimum_version to front

* link nsl

* fix patch_type

* fix properties

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

---------

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toge @conan-center-bot @uilianries @prince-chrismc @jwillikers @SpaceIm